In the parent issue, we introduced support for environment variables for the secrets of vantiv gateway configurations. But in that initial implementation, we used a single set of global (for all Vantiv gateways) 'API' environment variables. In order to support multiple concurrent Vantiv payment gateway configurations, we need to look for environment variables keyed by the machine name of the gateway configurations.

Comments

steveoliver created an issue. See original summary.

  • steveoliver committed f65667d on 8.x-1.x 
    Issue #2905519 by steveoliver: Support environment variables per gateway...
bojanz’s picture

bojanz commented

The idea of this module implementing its own env variable support is very wrong.

Drupal has a generic mechanism for this, documented here: https://docs.drupalcommerce.org/commerce2/developer-guide/payments/overr...

The settings.php values can all be taken from $_ENV.

steveoliver’s picture

steveoliver commented
Status: Active » Fixed

Of course! Thanks, @bojanz. I've opened a separate issue to change this implementation.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.