The submodule Commerce Order Cleanup Vars UI potentially displays a list of infomration at an admin URL defined by that module (admin/commerce/config/order-cleanup-vars-ui).

Rather than display information there, it's preferential to instead display that information on the admin page that the Commerce Order Cleanup provides (admin/commerce/config/order-cleanup).

CommentFileSizeAuthor
#11 commerce_order_cleanup-rearrange-submodule-display-2397277-11.patch9.14 KBalex_sansom
#6 commerce_order_cleanup-rearrange-submodule-display-2397277-6.patch9.13 KBalex_sansom
#6 simpletest-results.txt5.54 KBalex_sansom
#3 commerce_order_cleanup-rearrange-submodule-display-2397277-3.patch8.4 KBalex_sansom
#3 simpletest-results.txt5.57 KBalex_sansom

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Version: 7.x-1.2 » 7.x-1.x-dev
Category: Feature request » Task
Priority: Minor » Normal

Agreed, as we got the module already in, setting it as normal priority and task instead of feature request. Thanks!

alex_sansom’s picture

alex_sansom commented
Title: Dsplay submodule information on Commerce Order Cleanup admin page » Display submodule information on Commerce Order Cleanup admin page
alex_sansom’s picture

alex_sansom commented
StatusFileSize
new simpletest-results.txt5.57 KB
new commerce_order_cleanup-rearrange-submodule-display-2397277-3.patch8.4 KB

.patch attached that achieves what's described in the issue description.

Included in the patch are a couple of SimpleTest tests, the results of running locally before generating the patch are also attached.

alex_sansom’s picture

alex_sansom commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: commerce_order_cleanup-rearrange-submodule-display-2397277-3.patch, failed testing.

alex_sansom’s picture

alex_sansom commented
StatusFileSize
new simpletest-results.txt5.54 KB
new commerce_order_cleanup-rearrange-submodule-display-2397277-6.patch9.13 KB

OK. New .patch attached.

- Achieves what's described in the issue description
- Adds a couple of SimpleTest tests
- Renames the module from 'commerce_order_cleanup_vars_ui' to 'commerce_order_cleanup_ui' (requested offline)

Also attached are Simpletest results before generating the .patch file.

alex_sansom’s picture

alex_sansom commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: commerce_order_cleanup-rearrange-submodule-display-2397277-6.patch, failed testing.

Status: Needs work » Needs review

vijaycs85 queued 6: commerce_order_cleanup-rearrange-submodule-display-2397277-6.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 6: commerce_order_cleanup-rearrange-submodule-display-2397277-6.patch, failed testing.

alex_sansom’s picture

alex_sansom commented
StatusFileSize
new commerce_order_cleanup-rearrange-submodule-display-2397277-11.patch9.14 KB

Updated .patch groups the module tests under 'Commerce Order Cleanup' rather than 'Commerce (contrib)'.

  • vijaycs85 committed 77a629d on 7.x-1.x authored by alex_sansom 
    Issue #2397277 by alex_sansom: Display submodule information on Commerce...
vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.