Editing the profile of a user that purchased a license for a role, always deletes his role.
As can be seen in the attached image, it is not possible to toggle that role on/off, since "the role is granted by a license".
But without touching any fields - clicking on 'save' - will remove the role that was purchased.
Changes to the (licensed) role should be always locked, but should not be removed by editing the user profile.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | screenshot-with-patch#2.png | 41.65 KB | shaal |
| #2 | 2984036-fix-user-form-submit-bug.patch | 678 bytes | webadpro |
| license_role_on_user_profile.png | 46.09 KB | shaal |
Comments
Comment #2
webadpro commentedHere's a patch, on my end this fixes the issue.
Please review.
Comment #3
webadpro commentedComment #4
shaalPatch #2 fixes the bug of automatically remove the role after saving the profile.
But it introduces a new issue - it removes the warning message "This role is granted by a license. It cannot be removed manually." and it removes the lock that should be there to prevent us from accidentally switching off the role the user has purchased.
Comment #5
joachim commentedThis looks like a bug in FormAPI, or in the user module form.
Disabling a form element shouldn't cause the value to change.
Comment #6
joachim commentedCore bug: #2911473: Selected yet disabled individual options from checkboxes element don't persist through save.
Comment #7
joachim commentedConfirming that the problem is fixed with my latest patch on that core issue.
I'll add a note to the README here to say that core patch is required.
Comment #9
joachim commentedCredited everyone for discovery & working on a fix & review.
Going to make a new alpha, with a mention of this in the release notes, as this is a pretty big bug.
Comment #10
shaal@joachim wrote a patch for Drupal more details here.
Do not get confused with patch #39 which is intended for Drupal 8.6.x
You want to use patch #37 for Drupal 8.5.5
Hopefully, the patch will make it into Drupal 8.6 and won't be necessary once Drupal 8.6 comes out.
Comment #11
shaalComment #12
joachim commented> @joachim wrote a patch for Drupal CORE 8.5.5
Just to be clear, I rerolled someone else's patch :) -- credit is on the core issue.