Work to use AdminHtmlRouteProvider route provider instead of routing using YAML files

CommentFileSizeAuthor
#2 2926695-2-Change-routes-to-use-AdminHtmlRouteProvider-route-provider.patch2.56 KBgeroldk

Comments

geroldk created an issue. See original summary.

geroldk’s picture

geroldk commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2926695-2-Change-routes-to-use-AdminHtmlRouteProvider-route-provider.patch2.56 KB

First patch attached

  • joachim committed dbe2838 on 8.x-2.x authored by geroldk 
    Issue #2926695 by geroldk: Changed entity routes to use...
joachim’s picture

joachim commented
Status: Needs review » Fixed

Committed! Thanks!

The page admin/commerce/licenses/create still crashes, but I'm happy to commit this patch, as the crash is to do with the form itself rather than routing.

Next steps for the admin UI will be:

- change the path to admin/commerce/licenses/add, which is the standard format core uses
- add an 'add-page' template -- see getAddPageRoute in the routing controller
- check what getAddFormRoute() is doing with the bundle key. I hacked the form quickly to make it not crash and something else crashed which made me think something there is going wrong.
- fix/remove LicenseCreateForm.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.