When looking at a license revision I want to know the UID of the user who made the change (even if it's usually 0, indicating Drush).

CommentFileSizeAuthor
#9 commerce_license-revision-2653336-9.patch3.55 KBpjcdawkins
#8 commerce_license-revision-2653336-8.patch3.54 KBpjcdawkins
#4 commerce_license-revision_uid-2653336-4.patch2.45 KBpjcdawkins
#3 commerce_license-revision_uid-2653336-3.patch2.45 KBpjcdawkins
#2 commerce_license-revision_uid-2653336-2.patch2.35 KBpjcdawkins

Comments

pjcdawkins created an issue. See original summary.

pjcdawkins’s picture

pjcdawkins commented
Status: Active » Needs review
StatusFileSize
new commerce_license-revision_uid-2653336-2.patch2.35 KB
pjcdawkins’s picture

pjcdawkins commented
StatusFileSize
new commerce_license-revision_uid-2653336-3.patch2.45 KB

Defaulting the column to NULL, and explaining why

pjcdawkins’s picture

pjcdawkins commented
StatusFileSize
new commerce_license-revision_uid-2653336-4.patch2.45 KB

Oops. And this one matches the spec in the update function with the one in hook_schema.

Status: Needs review » Needs work

The last submitted patch, 4: commerce_license-revision_uid-2653336-4.patch, failed testing.

The last submitted patch, 4: commerce_license-revision_uid-2653336-4.patch, failed testing.

pjcdawkins’s picture

pjcdawkins commented
Status: Needs work » Needs review

CI error, not a failure

pjcdawkins’s picture

pjcdawkins commented
Title: Save the UID on revisions » Save UIDs and log messages on revisions
StatusFileSize
new commerce_license-revision-2653336-8.patch3.54 KB

New patch which adds a 'log' column (like commerce_order), and also allows the default values for revision_created/revision_ended/revision_uid to be overridden.

pjcdawkins’s picture

pjcdawkins commented
StatusFileSize
new commerce_license-revision-2653336-9.patch3.55 KB

Fix typo

The last submitted patch, 8: commerce_license-revision-2653336-8.patch, failed testing.

The last submitted patch, 8: commerce_license-revision-2653336-8.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 9: commerce_license-revision-2653336-9.patch, failed testing.

The last submitted patch, 9: commerce_license-revision-2653336-9.patch, failed testing.

pjcdawkins’s picture

pjcdawkins commented
Status: Needs work » Needs review
pjcdawkins’s picture

pjcdawkins commented
Assigned: Unassigned » Kazanir
Kazanir’s picture

Kazanir commented

We've been using this for ages. I added property info so that Views gets revision fields from the property/schema automatically and we should be all set.

  • Kazanir committed 8149ab3 on 7.x-1.x authored by pjcdawkins 
    Issue #2653336 by pjcdawkins, Kazanir: Save UIDs and log messages on...
Kazanir’s picture

Kazanir commented
Kazanir’s picture

Kazanir commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.