RC3 released.

CommentFileSizeAuthor
#2 update_commerce_add_to-2910644-2.patch587 bytesmglaman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Active » Needs review
FileSize
update_commerce_add_to-2910644-2.patch587 bytes

Patch

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented

PR https://github.com/commerceguys/commerce_kickstart/pull/244

deggertsen’s picture

deggertsen CreditAttribution: deggertsen commented
Status: Needs review » Reviewed & tested by the community

Looks good. This definitely needs to be updated.

We might want to let people know that there are significant CSS updates in this version and they will need to make sure their theme is compatible.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented
Status: Reviewed & tested by the community » Needs work

The Behat tests fail. I don't know if it's just testing needing updating, or something regressed. deggertsen did you manually test?

deggertsen’s picture

deggertsen CreditAttribution: deggertsen commented

@mglaman, so I just tried it again right now. If I do a git clone then the patch applies cleanly, but if I download the dev version it won't apply. I'm guessing that's because when you download the dev version it downloads drupal as well, not just the commerce_kickstart profile. I'm not super familiar with profiles as I personally don't use them so I'm not sure how to fix the issue.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Centarro commented

I'll have to just give it a good ole manual test. The functional test cannot find the "go to checkout" button, so I just want to make sure there isn't an actual regression.

deggertsen’s picture

deggertsen CreditAttribution: deggertsen commented
Status: Needs work » Needs review

Sounds good @mglaman. Thanks for looking into it!

sja1’s picture

sja1 CreditAttribution: sja1 commented

Although this is still set to needs review, it looks like commerce kickstart 7.x-2.53 did indeed include the updated version of this module.

It broke the styling of the add to cart confirmation popup on my site. I logged a bug with first stab at a patch here: #2958427: Add to cart confirmation popup styling is broken

rszrama’s picture

rszrama CreditAttribution: rszrama at Centarro commented
Status: Needs review » Closed (outdated)

Commerce Kickstart 2.x is in minimal maintenance mode. Closing out all outdated tickets now to maintain focus on Commerce Kickstart 3.x.