Closed (outdated)
Project:
Commerce Kickstart
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
21 Sep 2017 at 18:35 UTC
Updated:
30 Sep 2022 at 20:15 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mglamanPatch
Comment #3
mglamanPR https://github.com/commerceguys/commerce_kickstart/pull/244
Comment #4
deggertsen commentedLooks good. This definitely needs to be updated.
We might want to let people know that there are significant CSS updates in this version and they will need to make sure their theme is compatible.
Comment #5
mglamanThe Behat tests fail. I don't know if it's just testing needing updating, or something regressed. deggertsen did you manually test?
Comment #6
deggertsen commented@mglaman, so I just tried it again right now. If I do a git clone then the patch applies cleanly, but if I download the dev version it won't apply. I'm guessing that's because when you download the dev version it downloads drupal as well, not just the commerce_kickstart profile. I'm not super familiar with profiles as I personally don't use them so I'm not sure how to fix the issue.
Comment #7
mglamanI'll have to just give it a good ole manual test. The functional test cannot find the "go to checkout" button, so I just want to make sure there isn't an actual regression.
Comment #8
deggertsen commentedSounds good @mglaman. Thanks for looking into it!
Comment #9
sja1 commentedAlthough this is still set to needs review, it looks like commerce kickstart 7.x-2.53 did indeed include the updated version of this module.
It broke the styling of the add to cart confirmation popup on my site. I logged a bug with first stab at a patch here: #2958427: Add to cart confirmation popup styling is broken
Comment #10
rszrama commentedCommerce Kickstart 2.x is in minimal maintenance mode. Closing out all outdated tickets now to maintain focus on Commerce Kickstart 3.x.