Hi,

I noticed that the hp slideshow view does only show the pictures when ran from a non frontpage. The layout is broken and the slides are not animated.

any ideas?

Comments

jsacksick’s picture

jsacksick commented

The js is only added on the frontpage, maybe it should be done differently by adding it on a preprocess view or writing a views plugin.

/**
 * Implements hook_preprocess_page().
 */
function commerce_kickstart_slideshow_preprocess_page(&$vars) {
  if ($vars['is_front']) {
    drupal_add_library('commerce_kickstart_slideshow', 'bxslider');
  }
}

As a quickfix, you can try to comment out the condition $vars['is_front'] and tell us if it solves anything.

rfamans’s picture

rfamans commented
Status: Active » Fixed

Yes, works great! We have a letterbox style slideshow for which there is sufficient space on each productlist page so that's why we did not want to restrict the slideshow to frontpage only.

Thanks for your help.

bojanz’s picture

bojanz commented
Category: support » bug
Status: Fixed » Active

We should fix this.

summit’s picture

summit commented

Hi,
Yes please. And please make the layout at the bottom of the slideshow (bxslider: <==> <==> <==>) theme independent.
Now when I try this on my own theme. Theses are not shown.

Thanks for this great slideshow by the way!
greetings, Martijn

vasike’s picture

vasike
Location Ramnicu Valcea
commented
Version: 7.x-2.0-rc4 » 7.x-2.x-dev
Status: Active » Needs review

and here is the commit for this : https://code.drupalcommerce.org/#/c/560/.
thanks

bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.