If for some reason the MerchantReference or EmailAddress does not mach the expected results an error will be thrown as it tried to gather the actual return values from an undefined variable ($payment should be $response)

This was added in commit http://drupalcode.org/project/commerce_dps.git/commit/ba7cf88.

CommentFileSizeAuthor
#1 commerce_dps-local-validation_mismatch_info_fix-2124513-0.patch1.54 KBcraigstanton

Comments

craigstanton’s picture

craigstanton commented
StatusFileSize
new commerce_dps-local-validation_mismatch_info_fix-2124513-0.patch1.54 KB

Fixed by changing references to $payment to $response

craigstanton’s picture

craigstanton commented
Status: Active » Needs review
xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented

Thanks, will test this out, it looks fine.

Did you run into this when using sub-addressed emails (ex user+test123@example.org)?

That is a known issue (#1928454: Orders containing + sign may fail transaction validation) which appears to be at DPS side. Bit of a pain for testing, and for shoppers who sub-address emails to track spam.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Issue summary: View changes
Status: Needs review » Fixed
Related issues: +#1928454: Orders containing + sign may fail transaction validation

Thanks Craig, committed in http://drupalcode.org/project/commerce_dps.git/commit/6b9050a

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.