Add support for the new European SEPA Direct Debit standard

I created a patch for this integration. I added a variable for enable sepa or not. When you enable is showed a textfield for request IBAN/BIC code.

Created a new version with validation of IBAN and SWIFT code.

Created a new patch for old versions.

some improve in the patch.

Added some fix.

Added some fix.

Added to patch integration with views.

Hello Fastangel, one question and one comment...

Question: Of the patches you have uploaded, does more than one need to be applied? Do they apply to the stable 1.0 release or the 1.x dev release?

Comment: The maintenance status of this module is "Seeking new maintainer.", and the development status is "No further development." I point this out in case you might be interested in contacting the owner to take over maintenance.

New update.

Fix broken patch by fastangel.

Dang, did not work.

Rebuilt patch by hand against latest 7.x-1.x branch.

I changed a little description text.

This patch seems very important to me and should be integrated into the current .dev release as soon as possible. Thank you so much for your great work!

Removed eregi and change to preg_replace.

Sorry some fixed. I talked with the owner to add this patch to dev version.

New patch with some title changes. This weekend I will pass to dev version.

I thought a bit about this and I'm not sure if perhaps a separate module or at least a module rename would make sense.

Some reasons:
1. The name of the payment still contains "UK", which is not right for the SEPA case
2. A separate module would make development easier and better split up different cases. I think it would also speed up development.
3. Users can decide when to switch by using the Direct Debit SEPA module and the UK module would be kept clean

What's your oppinion?

I've tested your patch - many things seem to work fine but the validation function doesn't seem correct.

If I enter correct BIC and IBAN the form tells me "Your sort code must contain 6 numbers." as error, which is wrong.

Furthermore please keep in mind that it should be possible to (optionally) split the IBAN in groups for easier input. Example: DEXX XXXX XXXX XXXX XXXX XX

This should not trigger an error for usability reasons I think.

Thanks a lot for your response. As described above, this was just a suggestion. The "UK" is also somewhere in the rules I think... I'll look it up but I'm sure that I've seen it somewhere on the Shop-Website itself.

By the way: We need the module for a German website, so independency from the British special cases is important to us, if we don't start a separate project (which would be sad I think) :)

Thanks a lot again.

Pushed to dev branch and working in the changes commented #18

I've just tested the new version. Now I have two separate payment methods available in rules:

• UK Lastschrift Zahlungsmethode
• UK Direct Debit payment method (SEPA)

The first one can be editied in rules (as before). The second one has no options if I try to edit it. It also displays no value in the payment options (but can be selected as payment method by clients).

Furthermore the first one still has the same validation problems, but that might be correct?

This doesn't work for me at all. If I enter correct values for BIC / IBAN in the "old" payment method (UK) then I always receive the error:

Your sort code must contain 6 numbers.

What am I doing wrong and could you perhaps provide some examples for correct values? Could you have a try in your environment?

Ok I just debugged a bit and the reason is the following:

If I enable the "Enable SEPA integration" checkbox, the field "sort_code" does not exist anymore. But it is being checked in function "commerce_directdebit_submit_form_validate" which so always fails.

There is some duplicate code in link 235 which should be removed, I think.

I think that you are confused. If you want to enter BIC/IBAN you need to enable the checkbox in the rules in other case the code that you need is how the old module. More clear now?

Sorry there is some misunderstanding.

The problem is, that there is some duplicate code in the module which ALWAYS checks the sort_code, even if SEPA is enabled. I've removed it and now everything is logical and works fine :)
Sorry for the confusion. You shoud correct this in the .dev release:

Original from the code (mind the duplication of "Validate sort code"):

// Validate sort code
  if (strlen(preg_replace('/[^0-9]+/', '', $sort_code)) < 6) {
    form_set_error(implode('][', array_merge($form_parents, array('sort_code'))), t('Your sort code must contain 6 numbers.'));

    // Even though the form error is enough to stop the submission of the form,
    // it's not enough to stop it from a Commerce standpoint because of the
    // combined validation / submission going on per-pane in the checkout form.
    return FALSE;
  }

  $settings = $payment_method['settings'];

  //IF is SEPA validate iban and swift
  if ($settings['merchant_enable_sepa']) {
    //Validate IBAN
    if (!commerce_directdebit_verify_iban($pane_values['iban'])) {
      form_set_error(implode('][', array_merge($form_parents, array('iban'))), t('Your IBAN code is invalid.'));
      return FALSE;
    }

    //Validate SWIFT code
    if(!preg_match("/^([a-zA-Z]){4}([a-zA-Z]){2}([0-9a-zA-Z]){2}([0-9a-zA-Z]{3})?$/", $pane_values['swift'])) {
      form_set_error(implode('][', array_merge($form_parents, array('swift'))), t('Your BIC code is invalid.'));
      return FALSE;
    }
  }
  else {
    // Validate sort code
    if (strlen(preg_replace('/[^0-9]+/', '', $pane_values['sort_code'])) < 6) {
      form_set_error(implode('][', array_merge($form_parents, array('sort_code'))), t('Your sort code must contain 6 numbers.'));
      // Even though the form error is enough to stop the submission of the form,
      // it's not enough to stop it from a Commerce standpoint because of the
      // combined validation / submission going on per-pane in the checkout form.
      return FALSE;
    }
    // Validate account number
    if (strlen(preg_replace('/[^0-9]+/', '', $pane_values['account_number'])) < 8) {
      form_set_error(implode('][', array_merge($form_parents, array('account_number'))), t('Your account number must contain 8 numbers.'));

      // Even though the form error is enough to stop the submission of the form,
      // it's not enough to stop it from a Commerce standpoint because of the
      // combined validation / submission going on per-pane in the checkout form.
      return FALSE;
    }
  }

Thanks a lot for your quick reply.

uhmm yes looks like that my patch was bad. I will try fix this afternoon. Thanks.

fixed and commited.