This depends on #1992870: Various small fixes and #1992878: Move functions to include files being applied.
Your Source (skilip and/or naveko) built the functionality to handle 'push' requests from the Buckaroo system. I did a bit of cleanup and made a custom hook invocation, to move their client specific code into.
I hope I edited the patch file attribution correctly to ease attribution.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 1992880-3.patch | 10.19 KB | roderik |
| #2 | 1992880-2.patch | 8.79 KB | roderik |
| #1 | 1992880-1.patch | 7.61 KB | roderik |
| commerce_buckaroo-push.patch | 7.42 KB | roderik |
Comments
Comment #1
roderikSlight cleanup (comments, watchdog message)
Comment #2
roderikOK I did some reprogramming on the code now.
It now also saves new transactions with a status other than 'success'. If there's another push request with the same invoice number, it will update the transaction only if the status is 'success' (I felt that it would be too much of a functionality change to the existing code otherwise, which is live somewhere).
Comment #3
roderikhmz :-/ Juggling several patches at the same time is difficult.
I found something in commerce_buckaroo_redirect_form_validate() which is possibly confusing now.
I did not change it (at least functionally) -- just commented it. I didn't want to intrude on the code I have running on a live site, which is apparently working well.
Let's have a (theoretical) code reviewer give comments on that first ;)