Closed (works as designed)
Project:
Comment limit
Version:
8.x-1.0-alpha1
Component:
Code
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
29 Sep 2016 at 10:32 UTC
Updated:
21 Mar 2021 at 09:11 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
daiwik.addweb commentedApply following patch to make things work flawlessly.
Comment #3
daiwik.addweb commentedComment #4
didebruHey @NerdyCrowd thanks for your kind words.
Did you set the permission to the user that should edit their own comments?
Because this permission isn't set by default.
Comment #5
didebruWhy we don't check if it is a instance of Drupal\field\Entity\FieldConfig
instead of is_object?
And of course get rid of that ugly php notice :)
Comment #6
johnnydarkko commentedRerolled patch with `instanceof` instead of `is_object` as suggested in #5. Also cleared a couple of undefined errors for $field_id and $field_label.
Comment #7
ivnishdel
Comment #8
johnnydarkko commentedI was getting a bunch of php warnings of missing indexes for various entity types. This approach seems outdated, but the patch in this other issue appears to address the problem for me: https://www.drupal.org/project/comment_limit/issues/3025007
Comment #9
ivnishI reopened this temporary. Needs test after commit this patch https://www.drupal.org/project/comment_limit/issues/3025007
Comment #10
ivnish