Your hook_uninstall should go in a comment_count_notify.install file.

Line 125 - it is odd to have a variable assignment outside of a function. If you need that to run early in processing you should put it in a hook_init.

There are code spacing and missing docblocks throughout the module. Please run the http://drupal.org/project/coder on minor settings for style, sql, and translation.

CommentFileSizeAuthor
#5 1136976_code_style.patch7.4 KBgreggles

Comments

fotuzlab’s picture

fotuzlab commented

modified code as per suggestions

fotuzlab’s picture

fotuzlab commented
Status: Active » Fixed
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Fixed » Needs work

This is not a high priority, but there are still some issues.

Spacing in comment_count_notify_help and comment_count_notify_cronapi is more spaces than it should be (just 2 per line per indentation).

There's not enough space before return $admin_email->mail; nor return $comment_count->comment_count; nor return system_settings_form($form);

fotuzlab’s picture

fotuzlab commented

Greg,
I am using coder module 6.x-2.0-beta1
It did not give me any such warning.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 1136976_code_style.patch7.4 KB

Here's a start.

Like I said, this is not critical but there are small issues here.

fotuzlab’s picture

fotuzlab commented

Thanx for the patch. I have applied it here http://drupalcode.org/sandbox/arijit/1127432.git/commit/67e93fb

fotuzlab’s picture

fotuzlab commented
Status: Needs review » Fixed
fotuzlab’s picture

fotuzlab commented
Version: » 6.x-1.0
Status: Fixed » Closed (fixed)