Problem/Motivation

Per drupal.org/project/drupal/issues/3302988, CssOptimizer->loadFile() will become a protected function.

This Class is instantiated in color.module and loadFile() is called there.

Proposed resolution

Use dependency injection to call loadFile from the color module, or write the color module's own loadFile function.

Issue fork color-3590780

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mdranove created an issue. See original summary.

znak made their first commit to this issue’s fork.

znak’s picture

znak commented
Assigned: Unassigned » znak

znak changed the visibility of the branch 3590780-dont-call-cssoptimizer to hidden.

znak opened merge request !17

znak’s picture

znak commented
Assigned: znak » Unassigned
Status: Active » Needs review

I updated the code in the module file to use services in the correct way. Please, check the PR

mdranove’s picture

mdranove commented
Status: Needs review » Needs work

Hmm Im not sure I understand, there are a lot of changes in the MR that are not related to the issue?

I think the MR should just be changing this line

$css_optimizer = new CssOptimizer(\Drupal::service('file_url_generator'));

Unless I'm missing something.

mdranove’s picture

mdranove commented
Issue summary: View changes

mdranove opened merge request !18

mdranove’s picture

mdranove commented
Status: Needs work » Needs review