Problem/Motivation

When adding a suggested schema config, it suggests the label "@label (suggested)". It doesn't really help in any way, and it leads to an ugly machine name (like: collect_fetch_url_suggested_)

Proposed resolution

In SchemaBase::suggestConfig(), just use the schema label directly.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#7 collect-skip_adding_suggested_to_schema_configs.patch642 bytesedurenye
#5 interdiff-collect-skip_adding_suggested_to_schema_configs-2.txt527 bytesedurenye
#5 collect-skip_adding_suggested_to_schema_configs.patch609 bytesedurenye
#3 interdiff-collect-skip_adding_suggested_to_schema_configs.txt521 bytesedurenye
#3 collect-skip_adding_suggested_to_schema_configs-delete_t_call.patch647 bytesedurenye
#1 collect-skip_adding_suggested_to_schema_configs.patch667 bytesedurenye

Comments

edurenye’s picture

edurenye commented
Status: Active » Needs review
StatusFileSize
new collect-skip_adding_suggested_to_schema_configs.patch667 bytes

Now It does not add the "suggested" suffix.

arla’s picture

arla commented
Status: Needs review » Needs work

Thanks! Actually now that there's no English in there, there's no need for the t() call. $this->getLabel() is enough as a label.

edurenye’s picture

edurenye commented
Status: Needs work » Needs review
StatusFileSize
new collect-skip_adding_suggested_to_schema_configs-delete_t_call.patch647 bytes
new interdiff-collect-skip_adding_suggested_to_schema_configs.txt521 bytes

Delete t() call.

arla’s picture

arla commented
Status: Needs review » Needs work

With the latest patch, the label is an array but it should be a string. Just 'label' => $this->getLabel(), should be enough.

You should test it yourself (I admit it's tricky because there's no good documentation of this module yet).

  1. Enable the Collect module in Drupal (on the admin/modules page or with drush en)
  2. Go to admin/content/collect/url, enter an url and submit
  3. View the resulting container
  4. Click the "Set up a Collect Fetch URL schema" button in the top

The latest patch happens to work just fine, but we should really set it to a string :)

edurenye’s picture

edurenye commented
Status: Needs work » Needs review
StatusFileSize
new collect-skip_adding_suggested_to_schema_configs.patch609 bytes
new interdiff-collect-skip_adding_suggested_to_schema_configs-2.txt527 bytes

Solved

Status: Needs review » Needs work

The last submitted patch, 5: collect-skip_adding_suggested_to_schema_configs.patch, failed testing.

edurenye’s picture

edurenye commented
Status: Needs work » Needs review
StatusFileSize
new collect-skip_adding_suggested_to_schema_configs.patch642 bytes
arla’s picture

arla commented
Status: Needs review » Fixed

Thanks! Committed and pushed!

  • Arla committed 7efb13f on 8.x-1.x authored by edurenye 
    Issue #2454541 by edurenye: Skip adding "(suggested)" to schema configs

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.