When I added more than one cloudinary effect to the image style only last one was applied and others were ignored.
Here is fix to chain all effects.

CommentFileSizeAuthor
#4 Screenshot 2020-02-03 at 13.07.21.png28.06 KBPhil Wolstenholme
#2 2983418-cloudinary-multiple-effects-for-style-1.patch1.28 KBberdyshev
multiple-effects.patch1.42 KBberdyshev

Comments

berdyshev created an issue. See original summary.

berdyshev’s picture

berdyshev commented
StatusFileSize
new 2983418-cloudinary-multiple-effects-for-style-1.patch1.28 KB

fixed patch paths

Phil Wolstenholme’s picture

Phil Wolstenholme commented
Status: Needs review » Needs work

Edit: I have misunderstood named transformations vs chained transformations so I am not sure my comments are valid anymore.

It might be unrelated, but having applied this patch I'm noticing I'm getting incorrect transformation URLs when multiple named Cloudinary transformations are being used together:

With patch:

https://res.cloudinary.com/…/image/upload/s--54KiOQT_--/t_q_auto/t_f_auto/t_w_auto/t_c_limit/v1/2020-02/gilly-uItNiF1vv4E-unsplash.jpg?itok=C-a6Cfyy

The above returns a 400 error.

I think the URL format should be:

https://res.cloudinary.com/…/image/upload/s--54KiOQT_--/q_auto,f_auto,w_auto,c_limit/v1/2020-02/gilly-uItNiF1vv4E-unsplash.jpg?itok=C-a6Cfyy

-----

I've done some XDebugging:

With this patch, a call to Cloudinary::cloudinary_url($source, $options); is returning the incorrect URL ‌https://res.cloudinary.com/dywlbz3eg/image/upload/s--54KiOQT_--/t_q_auto... – I suspect we are passing data to the Cloudinary SDK that it does not expect.

Phil Wolstenholme’s picture

Phil Wolstenholme commented
StatusFileSize
new Screenshot 2020-02-03 at 13.07.21.png28.06 KB

I think this data structure might not be what the Cloudinary SDK expects?

Xdebug screenshot showing potentially too much nesting in an array

Phil Wolstenholme’s picture

Phil Wolstenholme commented
Status: Needs work » Needs review

Changing status back to needs review.