Problem/Motivation

The fix from [#3594984] was merged into 8.x and is present in 9.x, but it was not backported to 7.x. The affected route-provider methods on 7.x still declare ?\Serializable while returning Symfony\Component\Routing\Route, which causes a TypeError in functional tests.

Proposed resolution

Backport commit 50ca8b807 to 7.x, updating the four Cloud route-provider classes to declare ?Route.

Remaining tasks

  • Port the fix to 7.x.
  • Run validation and CI.

Issue fork cloud-3624257

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ai_yas created an issue. See original summary.

ai_yas opened merge request !2393

ai_yas’s picture

ai_yas commented
Status: Needs work » Needs review

MR !2393 targets 7.x and backports [#3594984].

The change replaces the incorrect ?\Serializable return types with ?Route in the four Cloud route providers.

Validation completed:

  • php -l passed for every changed PHP file.
  • git diff --check passed.

A GitLab pipeline is currently running for this MR.

ai_yas’s picture

ai_yas commented
Title: Fix route provider return types on 7.x » Fix incorrect route provider return types from ?\Serializable to ?Route on 7.x
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

I’ll merge the MR into 7.x and close this issue as Fixed.

  • ai_yas committed f29d1933 on 7.x 
    Issue #3624257 by yas, ai_yas: Fix CloudImageFormatter property type...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.