Problem/Motivation

  • Remove the hard-coded menu background color definitions in the SPA's index.css . Having them hard-coded affects the colors when the Rigel theme is switched from Dark to Light. Menu colors should be controlled in the theme css.

Issue fork cloud-3542982

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

baldwinlouie created an issue. See original summary.

baldwinlouie opened merge request !2346

baldwinlouie’s picture

baldwinlouie commented
Status: Active » Needs review

@yas, please review this patch. This adjusts the SPA's menu and table heading html elements so it relies on the theme for styling instead of hard-coded colors/styles.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

I’ll merge the patch into 7.x and 8.x; and close this issue as Fixed.

  • yas committed 05ea48f6 on 8.x authored by baldwinlouie 
    Issue #3542982 by baldwinlouie, yas: Remove menu background CSS from SPA...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@baldwinloiue

Can you make the MR for drupal/cloud:7.x-dev? Thanks

baldwinlouie opened merge request !2347

baldwinlouie’s picture

baldwinlouie commented
Status: Needs work » Needs review

@yas, I opened a MR for `7.x-dev` branch. Please review.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

Thank you for providing the patch for druapl/cloud:7.x-dev. I’ll merge the patch into 7.x, and close this issue as Fixed.

  • yas committed ea308ebc on 7.x authored by baldwinlouie 
    Issue #3542982 by baldwinlouie, yas: Remove menu background CSS from SPA...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.