Problem/Motivation

  • Migrate to native JavaScript from jQuery (aws_cloud_image_import.js)

Issue fork cloud-3407721

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Masami created an issue. See original summary.

masami’s picture

masami commented
Status: Active » Needs review

Masami opened merge request !2168

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Migrate to native JavaScript from jQuery (aws_cloud_image_import.js) » Refactor to native JavaScript from jQuery (aws_cloud_image_import.js)
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

@masami

Thank you for the patch. I posted my comment. Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work
masami’s picture

masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@masami

Thank you for the update. Can you please rebase the patch due to the previous merge? Thanks

masami’s picture

masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@masami

Can you please rebase it due to the previous merge? Thanks

masami’s picture

masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@masmai

Thank you for the update. Can you please rebase the patch again due to the previous merge? Thanks

masami’s picture

masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@masmai

Thank you for the update. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 0cdd34be on 6.x authored by Masami 
    Issue #3407721 by Masami, yas: Refactor to native JavaScript from jQuery...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@masmai

Can you please create the patch for 5.x-dev? Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@masami

I found the that ESLint got an error: https://git.drupalcode.org/issue/cloud-3407721/-/jobs/531592

Can you please create the hotfix besides the patch for 5.x-dev branch?

Thanks

Masami opened merge request !2188

Masami opened merge request !2189

masami’s picture

masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@masami

Thank you for the hotfix. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed ddf7f8b0 on 6.x authored by Masami 
    Issue #3407721 by Masami, yas: Hotfix - Refactor to native JavaScript...

  • yas committed 4cdae08a on 5.x 
    Issue #3407721 by Masami, yas: Refactor to native JavaScript from jQuery...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Masami opened merge request !2194

masami’s picture

masami commented
Status: Fixed » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@masami

Thank you for the hotfix. Can you please rebase the patch? Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@masmai

Thank you for the update. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@masmai

Sorry, can you please rebase the patch due to the previous merge? Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work
masami’s picture

masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@masami

Thank you for the hotfix. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 8f36fbcf on 6.x authored by Masami 
    Issue #3407721 by Masami, yas: Hotfix - Refactor to native JavaScript...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +chatgpt

@masami

Can you please create the hotfix for 5.x-dev, too? Thanks

Here is the error during merge:

error: patch failed: modules/cloud_service_providers/aws_cloud/aws_cloud.libraries.yml:45
error: modules/cloud_service_providers/aws_cloud/aws_cloud.libraries.yml: patch does not apply

yas opened merge request !2229

  • Masami authored d2ecaa69 on 5.x 
    Issue #3407721 by Masami, yas: Hotfix - Refactor to native JavaScript...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.