Problem/Motivation

  • Add an 'Add Interface' button in OpenStack Router interfaces form in SPA (drupal/cloud_dashboard).

Issue fork cloud-3396782

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !2074

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add a 'Add Interface' button in OpenStack Router interfaces screen in SPA (drupal/cloud_dashboard) » Add an 'Add Interface' button in OpenStack Router interfaces form in SPA (drupal/cloud_dashboard)
Issue summary: View changes
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the patch. I posted my comments. Thanks!

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the update. I posted my comment. Can you please check it? Thanks!

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas

I pushed a patch to replace "!== 2" to "< 2". Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. It looks good to me now. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 3976d3a0 on 6.x authored by Ryo Yamashita 
    Issue #3396782 by Ryo Yamashita, yas: Add an 'Add Interface' button in...

  • yas committed 29dcc156 on 5.x authored by Ryo Yamashita 
    Issue #3396782 by Ryo Yamashita, yas: Add an 'Add Interface' button in...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.