Problem/Motivation

  • Under the tabs of the resources, add the description such as “you do not have a permission to the resources” when a user does not have a permission to access the resources.
  • Focused on Cloud service provider’s permission

Issue fork cloud-3386610

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nakamurarts created an issue. See original summary.

nakamurarts opened merge request !1997

phyllanthus’s picture

phyllanthus commented
Status: Active » Needs review

yas made their first commit to this issue’s fork.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Needs work

@nakamurarts

Thank you for the patch. I posted my comment. According to the following modification, I think the patch is removing the existing testing for "No items." in the table. So please keep the existing test for "No items." in the table. In that sense,
you may want t add No items. and Access denied. into the new column such as a message in Examples: table of scenario.

- And I should "No items." in the table
+ And I should "Access denied." in the table

Because I see the following code in your patch:

  $message = $has_view_cloud_service_provider_permission ? t('No items.') : t('Access denied.');

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add the description when a user does not have access to the resources (1) (Cloud service provider) » Add a message when a user does not have access permission to the resources (Cloud service provider)
phyllanthus’s picture

phyllanthus commented
Status: Needs work » Needs review

@yas
Thank you for review.

Following a suggestion from a previous meeting, I have added a test case to `K8s-ATDD-01-01-ReadNoUserResources.feature` that checks for message changes due to user roles.

sekinet’s picture

sekinet commented
Status: Needs review » Needs work

@nakamurarts

I have posted some comments. Can you please check them?

phyllanthus’s picture

phyllanthus commented
Status: Needs work » Needs review

Only the addition of BDD test cases was performed, as the appropriate messages are already displayed now.

Also, fixed the permission name ('view own openstack flavor')

sekinet’s picture

sekinet commented
Status: Needs review » Reviewed & tested by the community

@nakamiurarts @yas

The patch looks good to me. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@sekinet

Thank you for your review.

@nakamurarts

Thank you for the update. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add a message when a user does not have access permission to the resources (Cloud service provider) » Add a BDD test suite when a user does not have access permission to the resources

  • yas committed 9b02215d on 6.x authored by nakamurarts 
    Issue #3386610 by yas, nakamurarts, sekinet: Add a BDD test suite when a...

  • yas committed a30fb0ff on 5.x authored by nakamurarts 
    Issue #3386610 by yas, nakamurarts, sekinet: Add a BDD test suite when a...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.