Problem/Motivation

  • Ensure that key pairs are automatically downloaded when they are created.
  • If this is difficult, add a reminder to always download.

Issue fork cloud-3372119

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !1876

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

Ryo Yamashita’s picture

Ryo Yamashita commented

@yas

I pushed a new patch to hide the message alert for downloading the secret key. Thanks.

asai.noriaki’s picture

asai.noriaki commented
Status: Needs review » Reviewed & tested by the community

@Ryo Yamashita @yas

Thank you for providing the patch. I tested that it works as expected, and it worked.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Download automatically when creating a key pair in SPA » Download an SSH private key immediately when creating a key pair in SPA (OpenStack)
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

@asai.noriaki

Thank you for your review.

@ryo-yamashita

I think we need more tests for this patch. Changed the status to Needs work. Thanks!

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas @asai.noriaki

The following changes were committed. Thanks.

  • Remove the alert that has a download link when the link is clicked
  • Remove all alert messages when the location is changed
  • Fix an issue that prevented the creation of AWS Cloud Key Pair
asai.noriaki’s picture

asai.noriaki commented
Status: Needs review » Needs work

@Ryo Yamashita @yas

Thank you for providing the patch. I tested that it works as expected.
- When I created the keypair, the private key was automatically downloaded. ---> OK
- When I deleted the keypair, the private key was not automatically downloaded. ---> OK
- But, after that, when I click the browser reload button, I got the following status message. ---> NG

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas @asai.noriaki

I fixed these errors. Thanks.

  • Fix an issue with "The @type @label has been created." alert message not being displayed when creating a key pair.
  • Fix an issue with the typo of "The @type @label has been deleted." alert message when deleting a key pair
asai.noriaki’s picture

asai.noriaki commented
Status: Needs review » Reviewed & tested by the community

@Ryo Yamashita @yas

Thank you for providing the patch. I tested that it works as expected, And it worked.

- When I created the keypair, the private key was automatically downloaded. ----> OK
And, the message "The Key pair test has been created." is displayed. ----> OK

- When I deleted the keypair, the private key was not automatically downloaded. ----> OK
And, the message "The Key pair test has been deleted." is displayed. ----> OK

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@asai.noriaki

Thank you for your review.

@ryo-yamashita

I tested the patch and it worked. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 3e51c898 on 6.x authored by Ryo Yamashita 
    Issue #3372119 by Ryo Yamashita, asai.noriaki, yas: Download an SSH...

  • yas committed 0020d2a1 on 5.x authored by Ryo Yamashita 
    Issue #3372119 by Ryo Yamashita, asai.noriaki, yas: Download an SSH...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.