Problem/Motivation

  • Fix status message displayed after creating/deleting a resource in the SPA version.

Issue fork cloud-3370824

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !1863

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Correct the message alerts (create/delete) in SPA » Fix the status message in SPA (Create / Delete)
Issue summary: View changes
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the patch. I posted my minor comment. Thanks

@asai.noriaki

What do you think?

asai.noriaki’s picture

asai.noriaki commented

@RyoYamashita @yas

Thank you for providing the patch. I tested that it works as expected and it worked.
The message when deleting the security group is OK. However, the message when creating a security group is NG.

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas @asai.noriaki

I pushed a fix commit. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@asai.noriaki

Thank you for your review. Can you please review the patch again?

@ryo-yamashita

Sorry, I haven't posted my review comment. Can you please check it? Thanks

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review
asai.noriaki’s picture

asai.noriaki commented
Status: Needs review » Reviewed & tested by the community

@Ryo Yamashita @yas

Thank you for providing the patch. I tested that it works as expected, and it worked.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@asai.noriaki

Thank you for your review. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed aa4485d9 on 6.x authored by Ryo Yamashita 
    Issue #3370824 by Ryo Yamashita, yas, asai.noriaki: Fix the status...

  • yas committed 4ff2f2fa on 5.x authored by Ryo Yamashita 
    Issue #3370824 by Ryo Yamashita, yas, asai.noriaki: Fix the status...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.