Problem/Motivation

  • Add "approve" feature to OpenStack quota (Implementation) (3) (Update list view)

Issue fork cloud-3356995

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan opened merge request !1762

xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add "approve" feature to OpenStack quota (Implementation) (3) (Update list view) » Add "approve" feature to OpenStack quota (3) (Update list view)
Status: Needs review » Needs work

@xiaohua-guan

Thank you for the patch. I posted my comment. Thanks

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review
xiaohua guan’s picture

xiaohua guan commented

@yas

Thanks for your comment. I've fixed it. Please take a look again. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@xiaohua-guan

Thank you for the update. Can you please update the BDD test scenario for the OpenStack quota since we'll update the key from quota_name_operate to quota_name?

Thanks!

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

I think I've fixed the BDD test scenario (OpenStack-ATDD-03-15-OperateQuotas.feature) in the last commit.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Sorry, I've missed that your patch was including the BDD test scenario change. I ran the BDD tests and it looks working fine. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed a30f1771 on 6.x authored by Xiaohua Guan 
    Issue #3356995 by Xiaohua Guan, yas: Add "approve" feature to OpenStack...

  • yas committed d11c0bb8 on 5.x authored by Xiaohua Guan 
    Issue #3356995 by Xiaohua Guan, yas: Add "approve" feature to OpenStack...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.