Problem/Motivation

  • Fix an error that sometimes occurred regarding the process of updating the list of Entities in OpenStack.

Issue fork cloud-3356744

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !1752

yas made their first commit to this issue’s fork.

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the fix. Can you consider the logic to convert a word to plural as follows? You can introduce a new method into CloudContentEntityTrait. The simple -s addition will cause a problem in the future.

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas

I updated this issue's commit. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the update. Please fix the following coding standard errors:

FILE: ...oot/modules/contrib/cloud/src/Traits/CloudContentEntityTrait.php
----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
 625 | ERROR | [x] Whitespace found at end of line
 627 | ERROR | [x] Parameter comment indentation must be 3 spaces,
     |       |     found 2 spaces
 628 | ERROR | [x] Whitespace found at end of line
 630 | ERROR | [x] Return comment indentation must be 3 spaces, found
     |       |     1 spaces
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Thanks

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas

I fixed the following coding standard errors. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Can you please check the test results? → https://www.drupal.org/pift-ci-job/2661227 It looks reproducible.

Thanks

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas

I pushed a patch to fix it so that it would pass the test. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the update. I posted my comment. Can you please check it? The DrupalCI error looks caused by a bug in the existing code. Thanks.

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas

I pushed a commit to correct the id_prural at the location in OpenStackKeyPair.php. Thanks.

Note: The existing method (getShortEntityTypeNamePluralCamelByTypeName()) will remove the necessary whitespace. Therefore, a new method (getShortEntityTypeNamePluralCamelByTypeNameWhitespace()) has been added.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

I posted my suggested refactoring based on the existing code so that we don't have to add the new method getShortEntityTypeNamePluralCamelByTypeNameWhitespace() w/ the similar logic as the existing one.

Thanks

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas

I have pushed the proposed modification, which is based on the existing method with fewer changes. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the update. I posted my comments. Thanks!

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas

I fixed codes according to coding standards. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@ryo-yamashita

Thank you for the update. It looks good to me now. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

  • yas committed f48fd418 on 6.x authored by Ryo Yamashita 
    Issue #3356744 by Ryo Yamashita, yas: Fix an error when updating the...

  • yas committed d3f6108a on 5.x authored by Ryo Yamashita 
    Issue #3356744 by Ryo Yamashita, yas: Fix an error when updating the...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Category: Task » Bug report

Ryo Yamashita opened merge request !1794

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs work

We found the BDD testing error, so we need the hotfix.

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the update. Can you please fix the coding standard errors?

→ https://www.drupal.org/pift-ci-job/2673980

Thanks

Ryo Yamashita’s picture

Ryo Yamashita commented
Status: Needs work » Needs review

@yas

i fixed doc comments for the cording standards. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. I ran the BDD tests and it looks good. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 48a2e383 on 6.x authored by Ryo Yamashita 
    Issue #3356744 by Ryo Yamashita, yas: Hotfix - Fix an error when...

  • yas committed e2fd28b7 on 5.x authored by Ryo Yamashita 
    Issue #3356744 by Ryo Yamashita, yas: Hotfix - Fix an error when...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.