Problem/Motivation

  • Fix typos

Issue fork cloud-3323738

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yas created an issue. See original summary.

yas opened merge request !1434

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review

@masami @ryo-yamashita @xiaohua-guan @baldwinlouie

Can you please review the patch? Thanks!

masami’s picture

masami commented

@yas
The patch looks good to me.

baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Needs work

@yas, Thank you for providing this patch. I've left my comments. They are mostly comments regarding capitalization.

Chandreshgiri Gauswami made their first commit to this issue’s fork.

chandreshgiri gauswami’s picture

chandreshgiri gauswami commented
Status: Needs work » Needs review

I have created MR with latest requested changes. Please review.

sekinet’s picture

sekinet commented

@yas
The patch looks good to me. Thanks.

xiaohua guan’s picture

xiaohua guan commented

@yas

It looks good to me. Thanks.

Ryo Yamashita’s picture

Ryo Yamashita commented

@yas

It looks good to me. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@chandreshgiri-gauswami
@xiaohua-guan
@masami
@baldwinlouie
@ryo-yamashita
@sekinet

Thank you for your review. It looks good, so I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • 7851381 committed on 5.x 
    Issue #3323738 by yas, Chandreshgiri Gauswami, Xiaohua Guan, Masami,...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

  • yas committed e5382ee on 4.x 
    Issue #3323738 by yas, Chandreshgiri Gauswami, Xiaohua Guan, Masami,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.