Problem/Motivation

  • Release 4.0.0

Issue fork cloud-3258116

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yas created an issue. See original summary.

yas opened merge request !602

yas closed merge request !602

yas opened merge request !603

Ryo Yamashita made their first commit to this issue’s fork.

sekinet made their first commit to this issue’s fork.

baldwinlouie made their first commit to this issue’s fork.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Needs work » Needs review
baldwinlouie’s picture

baldwinlouie CreditAttribution: baldwinlouie commented

@yas, The patch looks pretty good. I only have one comment.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented

@baldwinlouie

Thank you for your review. I updated cloud_dashboard/README.md. Could you please review it again? Thanks!

baldwinlouie’s picture

baldwinlouie CreditAttribution: baldwinlouie commented
Status: Needs review » Reviewed & tested by the community

@yas, it looks good to me now!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented

@baldwinlouie

Thank you for your review.

@ryo-yamashita

Could you please review the patch? Thanks!

Ryo Yamashita’s picture

Ryo Yamashita CreditAttribution: Ryo Yamashita commented

@yas

I understand. I just checked the operation.
There (commit of "adding replica_set detailed view", "Updated README.md for cloud_dashboard") seems to be no problem.

baldwinlouie’s picture

baldwinlouie CreditAttribution: baldwinlouie commented

@yas, I've added the cronjob detailed view for SPA.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented

@baldwinlouie

Thank you for the commit!

sekinet’s picture

sekinet CreditAttribution: sekinet commented

@yas, I've added the Resource Quotas detailed view for SPA.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented

@sekinet

Thank you for the commit!

Masami made their first commit to this issue’s fork.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Related issues: +#3260006: Add Sodium extension

We need to wait for the update of Drupal CI to upgrade drupal/simple_oauth:^5.2 due to the following error:

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - lcobucci/jwt 4.1.5 requires ext-sodium * -> it is missing from your system. Install or enable PHP's sodium extension.
    - drupal/simple_oauth[5.2.0, ..., 5.x-dev] require steverhoades/oauth2-openid-connect-server ^2.4 -> satisfiable by steverhoades/oauth2-openid-connect-server[v2.4.0].
    - drupal/cloud dev-merge-request-603 requires drupal/simple_oauth ^5.2 -> satisfiable by drupal/simple_oauth[5.2.0, 5.2.x-dev, 5.x-dev].
    - steverhoades/oauth2-openid-connect-server v2.4.0 requires lcobucci/jwt 4.1.5 -> satisfiable by lcobucci/jwt[4.1.5].
    - Root composer.json requires drupal/cloud merge-request-603-dev -> satisfiable by drupal/cloud[dev-merge-request-603].

See also #3260006: Add Sodium extension

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented

@all

The tests have been passed successfully, so I'll merge the patch to 4.x, and close this issue as Fixed.

  • yas committed 8e36ed4 on 4.x 
    Issue #3258116 by yas, sekinet, Ryo Yamashita, Masami, baldwinlouie:...

yas opened merge request !642

  • yas committed c82f035 on 4.x 
    Issue #3258116 by yas: Back to dev.
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.