Problem/Motivation

  • Fix a typo of README.mdfor docker.yaml in CFn: from docker.yml to docker.yaml
  • Itemize the S3 URLs like:
  • Change the descriptions

Issue fork cloud-3233607

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yas created an issue. See original summary.

yas opened merge request !402

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Active » Needs review
baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Needs work

@yas, Please check my comments. They are all just slight wording modifications.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review

@baldwinlouie

I updated the patch. Could you please review it again? Thanks

baldwinlouie’s picture

baldwinlouie commented

@yas, please check out the final comment. Aside from that, it looks good. Thank you for the patch.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinlouie

Thank you for your review. That's my mistake, could you please double-check it? Thanks!

baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Reviewed & tested by the community

@yas, looks good now! Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinlouie

Thank you for the review. I'll merge the patch to 3.x and 4.x and close this issue as Fixed.

  • yas committed c86b805 on 4.x 
    Issue #3233607 by yas, baldwinlouie: Update README.md for CFn templates

  • yas committed 8ddbe4e on 3.x 
    Issue #3233607 by yas, baldwinlouie: Update README.md for CFn templates

yas closed merge request !402

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs work

Needs to fix the coding standard violation of cfn/nested/README.md.

yas opened merge request !406

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Reviewed & tested by the community

@baldwinlouie

The tests have been passed successfully, Thank you for the review. I'll merge the patch to 3.x and 4.x and close this issue as Fixed.

  • yas committed aa1894b on 3.x 
    Issue #3233607 by yas: Update README.md for CFn templates

  • yas committed 88ed5c4 on 4.x 
    Issue #3233607 by yas: Hotfix - Update README.md for CFn templates
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

yas closed merge request !406

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.