Problem/Motivation

  • Limit # of AWS Cloud service provider to create
  • Change the default regions: No selection by default

Issue fork cloud-3233416

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

baldwinlouie created an issue. See original summary.

baldwinlouie opened merge request !401

baldwinlouie’s picture

baldwinlouie commented
Status: Active » Needs review

@yas, here is the patch to limit how many regions a user can add. It also doesn't check any regions when the form is loaded.

yas made their first commit to this issue’s fork.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinlouie

Thank you for the refactoring. I posted my comment above.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

Changing the status to Needs work

baldwinlouie’s picture

baldwinlouie commented
Status: Needs work » Needs review

attempting to fix unit test.

baldwinlouie’s picture

baldwinlouie commented

one more attempt for fixing unit tests,.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@baldwinlouie

Thank you for the update. I posted my comments above; and all comments are related to replacing from self::$awsMaxRegions to CloudConfigInterface::MAX_REGION_COUNT.

Thanks!

baldwinlouie’s picture

baldwinlouie commented
Status: Needs work » Needs review

@yas, updated the patch with your requests.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

Thank you for the update. It looks good to me now. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed 4a330ec on 4.x authored by baldwinlouie 
    Issue #3233416 by baldwinlouie, yas: Limit the number of AWS cloud...

yas closed merge request !401

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.