Problem/Motivation

Edit AWS Cloud Instance for REST API

Proposed resolution

Add a REST API to edit AWS Cloud Instance

Issue fork cloud-3231867

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !380

Ryo Yamashita’s picture

Ryo Yamashita CreditAttribution: Ryo Yamashita commented
Status: Needs work » Needs review

@yas

I have created a patch. Could you please check it?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the patch. I posted my comments. Please check the ones.

@xiaohua-guan @baldwinlouie

What do you think?

baldwinlouie’s picture

baldwinlouie CreditAttribution: baldwinlouie commented

@RyoYamashita @yas, Thank you for this patch. I left my comments.

Ryo Yamashita’s picture

Ryo Yamashita CreditAttribution: Ryo Yamashita commented
Status: Needs work » Needs review

@yas @baldwinlouie

Thank you for your various comments on the patch.
I have corrected the variable names, function comments, and other processing. Please check it.

baldwinlouie’s picture

baldwinlouie CreditAttribution: baldwinlouie commented

@yas and @ryo-yamashita, Thank you for the patch. It looks good to me!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

Thank you for your review.

@ryo-yamashita

Now the patch looks good, so I'll merge the patch to 4.x and close this issue as Fixed.

yas closed merge request !380

yas reopened merge request !380

  • yas committed acf615b on 4.x authored by Ryo Yamashita 
    Issue #3231867 by Ryo Yamashita, yas, baldwinlouie: Add a REST API to...

yas closed merge request !380

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.