Problem/Motivation

  • Change k8s configmap to k8s config_map in the permissions yaml file and places where it is declared in code.

Issue fork cloud-3222893

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

baldwinlouie created an issue. See original summary.

baldwinlouie opened merge request !303

baldwinlouie’s picture

baldwinlouie commented
Status: Active » Needs review

@yas, adding a `PR` that fixes the permission mismatch. During testing, I also found that the regex in k8s_query_k8s_entity_views_access_alter() doesn't catch the case when the All -> K8s Resources link is clicked.

  if (!preg_match('/^view\.([a-z0-9_]+)\.list$/', $route_name, $matches)) {
    return;
  }

This will only catch view.*.list listing page. It won't catch the view.*.all listing page.

I added support to the regex to support both view.*.list and view.*.all page like such

  if (!preg_match('/^view\.([a-z0-9_]+)\.(list|all)$/', $route_name, $matches)) {
    return;
  }
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Related issues: +#3222920: Fix a test case error at K8sRoleBindingTest::testUpdateAllRoleBindingList()

@baldwinlouie

Thank you for fixing the issue. It looks good to me.

@baldwinlouie @sekinet

The patch found another test case failure at K8sRoleBindingTest::testUpdateAllRoleBindingList().
I created the issue to be solved at #3222920: Fix a test case error at K8sRoleBindingTest::testUpdateAllRoleBindingList(). Could you please review that patch, too?

@xiaohua-guan

What do you think about this patch apart from #3222920: Fix a test case error at K8sRoleBindingTest::testUpdateAllRoleBindingList()?

Thanks

xiaohua guan’s picture

xiaohua guan commented

@yas

The patch file looks good to me.

And about "What do you think about this patch apart from #3222920: Fix a test case error at K8sRoleBindingTest::testUpdateAllRoleBindingList()?", I think it is a good idea.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for your review. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed e3acf74 on 4.x authored by baldwinlouie 
    Issue #3222893 by baldwinlouie, yas, Xiaohua Guan: Change "k8s configmap...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3222928: Change "k8s configmap" permissions to "k8s config_map" (3.x)

yas closed merge request !303

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.