Problem/Motivation
- In
k8s_query_k8s_entity_views_access_with_namespace_alter()function, add the remaining K8s routes to$target_route_namesarray
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | 3221336-3x-15.patch | 14.3 KB | baldwinlouie |
Issue fork cloud-3221336
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3221336-hot-fix
changes, plain diff MR !294
- 3221336-add-remaining-k8s
changes, plain diff MR !293
Comments
Comment #3
baldwinlouie commented@yas and @xiaohuaguan Please review this patch that modifies the
k8s_query_k8s_entity_views_access_alterandk8s_query_k8s_entity_views_access_with_namespace_alterfunctions.The patch does the following:
1. Merges the two
k8s_query_k8s_entity_views_access_alterandk8s_query_k8s_entity_views_access_with_namespace_alterfunctions into one since ALL K8s entities need to check forany/ownwhen building a listing page.2. Refactored the
K8s*ViewsData. I moved theaccess query taginto theK8sViewsDataBaseparent class, since all entities will now use it.Comment #4
yas@baldwinlouie
Thank you for the patch taking care of the K8s resource permissions. It looks good to me.
@xiaohua-guan
Could you please review the patch, too? What do you think?
Comment #5
xiaohua guan commented@baldwinlouie
Thanks for your patch. It looks good to me except that the code below in K8sNamespaceViewsData can be removed, I think.
Comment #6
baldwinlouie commented@xiaohuaguan, Thank you for the review. I've updated the PR with your feedback.
Comment #7
yas@xiaohua-guan
Please let us gives your thoughts as a final confirmation before we merge the patch.
Thanks
Comment #8
xiaohua guan commented@baldwinlouie @yas
Thanks for your new code. It looks good to me. Maybe in other ticket, we can remove
$namespaced_routes = []by checking whether there is namespace field in the entity type.Comment #9
yas@xiaohua-guan
Thank you for you review and suggestion. I'll merge the patch to
4.xand close this issue as Fixed.Yes, we should address that in another issue.
Thanks
Comment #12
yasComment #13
yas@baldwinlouie
I re-opened this issue due to a coding standard violation: https://www.drupal.org/pift-ci-job/2109620. Sorry but I didn't notice it.
Could you please create a patch for
3.xand a hotfix for4.x?Thanks
Comment #15
baldwinlouie commented@yas, attaching patch for 3.x branch as well.
Comment #16
baldwinlouie commentedComment #18
yas@baldwinlouie
Thank you for the updates. I'll merge the patch to
3.xand4.xand close this issue as Fixed.Comment #21
yas