Problem/Motivation

Add Cloud Orchestrator cloud service provider (9.7) (QueueWorker) (Convert payload) (VMware entities)

CommentFileSizeAuthor
#11 3221005-11.patch706 bytesxiaohua guan

Issue fork cloud-3221005

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan opened merge request !285

xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review

@yas

Please review the code. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@xiaohua-guan

Thank you for adding the supported module. I posted my comments for refactoring. Could you please check them? Thanks

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

I fixed the code. Please take a look again. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add Cloud Orchestrator cloud service provider (9.7) (QueueWorker) (Convert payload) (VMware entities) » Add Cloud Orchestrator cloud service provider (QueueWorker) (Convert payload) (VMware entities)
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the update. It looks good. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed 0dc61ba on 4.x authored by Xiaohua Guan 
    Issue #3221005 by Xiaohua Guan, yas: Add Cloud Orchestrator cloud...

yas closed merge request !285

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs work

@xiaohua-guan

Sorry, I found the test failed. Could you please create the patch for hotfix? Probably that array for supported entity array can be a constant in some interface rather than cloud_cluster_ module function?

xiaohua guan’s picture

xiaohua guan commented
StatusFileSize
new 3221005-11.patch706 bytes
xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review
xiaohua guan’s picture

xiaohua guan commented

@yas

I am sorry for the bug. Please check the patch file. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xiahua-guan

Thank you for the hotfix. I'll merge the patch to 4.x and close this issue as Fixed. Thanks

  • yas committed af37d65 on 4.x authored by Xiaohua Guan 
    Issue #3221005 by Xiaohua Guan, yas: Hotfix - Add Cloud Orchestrator...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.