Problem/Motivation

When testing IAM permission validation, I encountered these warning messages.

Steps to reproduce

  1. Start to Edit a cloud config provider.
  2. Set a user who doesn't have enough IAM permissions
  3. Disable IAM permission validation
  4. Save

Issue fork cloud-3220666

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kumikoono created an issue. See original summary.

kumikoono opened merge request !283

kumikoono’s picture

kumikoono commented
Status: Active » Needs review

@yas Can you review the fix and test cases I added?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@kumikoono

Thank you for fixing the issue. I posted my comments for refactoring. Also, please fix a couple of coding standard violations: https://www.drupal.org/pift-ci-job/2103642

Thanks

kumikoono’s picture

kumikoono commented
Status: Needs work » Needs review

@yas Thanks for your review. Your comments are incorporated into the new patch.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@kumikoono

I want confirm if the logic can be changed or not. Please check my comments above. Thanks

kumikoono’s picture

kumikoono commented

I fixed the test errors caused by the change in how to get a random index of the regions array.
This array is an associative array, so the array_rand returns string, not int. This caused the type errors in testing. So, I reverted the changes and added the comment.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@kumikoono

Thank you for fixing the test error. I posted my comments above. Could you please check them? Thanks

kumikoono’s picture

kumikoono commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@kumikoono

Thank you for the update. The patch looks good now. The tests have been passed successfully, so I'll merge the patch to 4.x, and close this issue as Fixed.

  • yas committed 5781dba on 4.x authored by kumikoono 
    Issue #3220666 by kumikoono, yas: Fix warnings with Ec2BatchOperations

yas closed merge request !283

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.