Problem/Motivation

Remove the resource schedule / allocation feature on K8s Cloud Project form

CommentFileSizeAuthor
#21 hotfix-3207595-21.patch750 bytesxiaohua guan
#15 hotfix-3207595-15.patch969 bytesyas
#4 3207595-4.patch48.23 KBxiaohua guan

Issue fork cloud-3207595

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Xiaohua Guan created an issue. See original summary.

xiaohua guan’s picture

xiaohua guan commented
Issue summary: View changes

Xiaohua Guan opened merge request !203

xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review
StatusFileSize
new 3207595-4.patch48.23 KB
xiaohua guan’s picture

xiaohua guan commented

@yas

Please review the commit code. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@xiaohua-guan

Thank you for the refactoring. I found an error. Please check my above comment. Thanks

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

Sorry for the mistake. I've fixed it. Please take a look again. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the update. I tested the patch and it looks good to me. I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed 541b0ac on 3.x authored by Xiaohua Guan 
    Issue #3207595 by Xiaohua Guan, yas: Remove the resource schedule /...

yas closed merge request !203

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
xiaohua guan’s picture

xiaohua guan commented
Assigned: Unassigned » xiaohua guan
Status: Fixed » Needs review

Xiaohua Guan opened merge request !207

xiaohua guan’s picture

xiaohua guan commented

@yas

I fixed the problem about install function. Please take a look. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new hotfix-3207595-15.patch969 bytes

@xiaohua-guan

Thank you for fixing the issue. I couldn't apply the patch since it is invalid so I re-created the patch as attached. Then I applied and tested the patch in my local testing environment, and it worked. Just in case, could you please review the patch that I re-created? Thanks

xiaohua guan’s picture

xiaohua guan commented
Status: Needs review » Reviewed & tested by the community

@yas

The patch is OK to me. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@xiaohua-guan

Thank you for your confirmation. I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed b638ac1 on 3.x authored by Xiaohua Guan 
    Issue #3207595 by Xiaohua Guan, yas: Hotfix - Remove the resource...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

yas closed merge request !207

xiaohua guan’s picture

xiaohua guan commented
Status: Fixed » Needs review
StatusFileSize
new hotfix-3207595-21.patch750 bytes
xiaohua guan’s picture

xiaohua guan commented

@yas

Please review the hotfix. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@xiaohua-guan

Thank you for fixing the issue. I tested the patch and had no error at all.

@kumikoono

What do you think?

kumikoono’s picture

kumikoono commented

The patch looked fixing the issue. "drush updb" went well at my dev env.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@kimikoono

Thank you for your review. I'll merge the patch to 3.x and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.