Problem/Motivation

Add test cases for K8s Schedule (Pod)

CommentFileSizeAuthor
#3 3201301-3.patch8.64 KBxiaohua guan

Issue fork cloud-3201301

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan opened merge request !166

xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review
StatusFileSize
new 3201301-3.patch8.64 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@xiaohua-guan

Thank you for adding the test cases. I just have one minor comment. Please check it. Thanks.

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

Thanks for your review. I've fixed the comment. Please confirm it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the update. It looks perfect. I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed c41fb2c on 3.x authored by Xiaohua Guan 
    Issue #3201301 by Xiaohua Guan, yas: Add test cases for K8s Schedule (...

yas closed merge request !166

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3201374: Add test cases for K8s Schedule (Launch Template)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.