Problem/Motivation

Specify a different user when launching a template or project.

CommentFileSizeAuthor
#16 hotfix-3201138-16.patch929 bytesmasami
#10 3201138-10.patch22.32 KBmasami
#9 20210302b1.png372.11 KByas
#9 20210302d.png442.13 KByas
#9 20210302c.png301.28 KByas
#9 20210302a.png281.97 KByas
#8 3201138-8.patch22.14 KBmasami
#4 3201138-4.patch21.73 KBmasami
#3 3201138.patch21.81 KBmasami

Issue fork cloud-3201138

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Masami created an issue. See original summary.

Masami opened merge request !165

masami’s picture

masami commented
Status: Active » Needs review
StatusFileSize
new 3201138.patch21.81 KB
masami’s picture

masami commented
StatusFileSize
new 3201138-4.patch21.73 KB

The last submitted patch, 3: 3201138.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 4: 3201138-4.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@masami

Thank you for adding the feature. Please check my above comment. Most of them are minor and cosmetic changes. Thanks.

masami’s picture

masami commented
Status: Needs work » Needs review
StatusFileSize
new 3201138-8.patch22.14 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
StatusFileSize
new 20210302a.png281.97 KB
new 20210302c.png301.28 KB
new 20210302d.png442.13 KB
new 20210302b1.png372.11 KB

@masami

Thank you for the update. I have the following comments:

  1. Add Project: Remove the username field
    20210302a.png
  2. Add a Username fieldset and move the Launch as field to that field
    20210302b.png
  3. Copy Project: Remove the username field
    20210302c.png
  4. Change the wordings
    20210302d.png
masami’s picture

masami commented
StatusFileSize
new 3201138-10.patch22.32 KB
masami’s picture

masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@masami

Thank you for the update. It looks good to me now. I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed fe7a7c4 on 3.x authored by Masami 
    Issue #3201138 by Masami, yas: Specify a different user when launching a...

yas closed merge request !165

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Thank you for the update. I merged the patch to 3.x and closing this issue as Fixed.

masami’s picture

masami commented
Status: Fixed » Needs review
StatusFileSize
new hotfix-3201138-16.patch929 bytes

@yas
I re-open this ticket and add a hotfix patch.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@masami

Thank you for the hotfix. I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed eee33a6 on 3.x authored by Masami 
    Issue #3201138 by Masami, yas: Hotfix - Specify a different user when...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.