Problem/Motivation

  • Change Cloud server template to Cloud launch template
  • Change Create 〜 to Add 〜
  • Add descriptions in cloud.permissions.yml
CommentFileSizeAuthor
#6 screenshot 2021-02-09 3.57.20.png1.32 MByas
#5 snBrJUk - Imgur.png26.35 KBilgnerfagundes
#3 3197433-3.patch124.47 KByas

Issue fork cloud-3197433

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yas created an issue. See original summary.

yas opened merge request !137

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Active » Needs review
StatusFileSize
new 3197433-3.patch124.47 KB

@baldwinlouie
@masatotakada
@sekinet

Could you please review the patch?

sekinet’s picture

sekinet commented

@yas I’ve checked the patch and it looks good.

ilgnerfagundes’s picture

ilgnerfagundes commented
Status: Needs review » Needs work
StatusFileSize
new snBrJUk - Imgur.png26.35 KB

I tried to run the patch it presented the following errors

~/Documentos/projetos/ci-t-website/drupal/web/modules/custom/cloud$ git apply -v 3197433-3.patch
Checking patch cloud.install...
Checking patch cloud.links.menu.yml...
Checking patch cloud.links.task.yml...
Checking patch cloud.permissions.yml...
Checking patch cloud.routing.yml...
Checking patch cloud_server_template.page.inc...
Checking patch config/cloud_server_template.api.php...
Checking patch modules/cloud_service_providers/aws_cloud/aws_cloud.install...
Checking patch modules/cloud_service_providers/aws_cloud/aws_cloud.module...
Checking patch modules/cloud_service_providers/aws_cloud/src/Entity/Ec2/AwsCloudViewBuilder.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Form/Ec2/InstanceLaunchForm.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Plugin/Derivative/AwsCloudMenuLinks.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Plugin/Field/FieldFormatter/InstanceTypeLinkFormatter.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Plugin/Validation/Constraint/AWSConstraintValidator.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Plugin/cloud/server_template/AwsCloudServerTemplatePlugin.php...
error: while searching for:
}

/**
* Update instance name based on the name of the cloud server template.
*
* If the same instance name exists, the number suffix (#2, #3…) can be
* added at the end of the cloud server template name.
*
* @param \Drupal\cloud\Entity\CloudServerTemplateInterface $cloud_server_template
* The cloud server template used to launch a instance.
* @param string $cloud_launch_uuid
* The uuid to specify instances.
*/

error: patch failed: modules/cloud_service_providers/aws_cloud/src/Plugin/cloud/server_template/AwsCloudServerTemplatePlugin.php:542
error: modules/cloud_service_providers/aws_cloud/src/Plugin/cloud/server_template/AwsCloudServerTemplatePlugin.php: patch does not apply
Checking patch modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2BatchOperations.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2ServiceInterface.php...
Checking patch modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/InstanceExtraTest.php...
Checking patch modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/InstanceTest.php...
Checking patch modules/cloud_service_providers/aws_cloud/tests/src/Functional/cloud/server_template/CloudServerTemplateTest.php...
Checking patch modules/cloud_service_providers/aws_cloud/tests/src/Traits/AwsCloudTestEntityTrait.php...
Checking patch modules/cloud_service_providers/aws_cloud/tests/src/Traits/AwsCloudTestFormDataTrait.php...
Checking patch modules/cloud_service_providers/k8s/k8s.install...
Checking patch modules/cloud_service_providers/k8s/k8s.module...
Checking patch modules/cloud_service_providers/k8s/src/Plugin/Validation/Constraint/YamlObjectSupportConstraint.php...
Checking patch modules/cloud_service_providers/k8s/src/Plugin/cloud/project/K8sCloudProjectPlugin.php...
Checking patch modules/cloud_service_providers/k8s/src/Plugin/cloud/server_template/K8sCloudServerTemplatePlugin.php...
Checking patch modules/cloud_service_providers/k8s/src/Service/K8sService.php...
Checking patch modules/cloud_service_providers/k8s/src/Service/K8sServiceInterface.php...
Checking patch modules/cloud_service_providers/k8s/tests/src/Functional/cloud/server_template/CloudServerTemplateTest.php...
Checking patch modules/cloud_service_providers/k8s/tests/src/Traits/K8sTestEntityTrait.php...
Checking patch modules/cloud_service_providers/k8s/tests/src/Traits/K8sTestFormDataTrait.php...
Checking patch modules/cloud_service_providers/openstack/openstack.module...
Checking patch modules/cloud_service_providers/openstack/src/Form/OpenStackInstanceLaunchForm.php...
Checking patch modules/cloud_service_providers/openstack/src/Plugin/Derivative/OpenStackMenuLinks.php...
Checking patch modules/cloud_service_providers/openstack/src/Plugin/cloud/server_template/OpenStackServerTemplatePlugin.php...
error: while searching for:
}

/**
* Update instance name based on the name of the cloud server template.
*
* If the same instance name exists, the number suffix (#2, #3…) can be
* added at the end of the cloud server template name.
*
* @param \Drupal\cloud\Entity\CloudServerTemplateInterface $cloud_server_template
* The cloud server template used to launch a instance.
* @param string $cloud_launch_uuid
* The uuid to specify instances.
*/

error: patch failed: modules/cloud_service_providers/openstack/src/Plugin/cloud/server_template/OpenStackServerTemplatePlugin.php:500
error: modules/cloud_service_providers/openstack/src/Plugin/cloud/server_template/OpenStackServerTemplatePlugin.php: patch does not apply
Checking patch modules/cloud_service_providers/openstack/tests/src/Functional/OpenStack/OpenStackInstanceExtraTest.php...
Checking patch modules/cloud_service_providers/openstack/tests/src/Functional/OpenStack/OpenStackInstanceTest.php...
Checking patch modules/cloud_service_providers/openstack/tests/src/Functional/cloud/server_template/CloudServerTemplateTest.php...
Checking patch modules/cloud_service_providers/openstack/tests/src/Traits/OpenStackTestEntityTrait.php...
Checking patch modules/cloud_service_providers/openstack/tests/src/Traits/OpenStackTestFormDataTrait.php...
Checking patch modules/cloud_service_providers/vmware/src/Plugin/cloud/server_template/VmwareCloudServerTemplatePlugin.php...
Checking patch modules/cloud_service_providers/vmware/tests/src/Functional/cloud/server_template/CloudServerTemplateTest.php...
Checking patch modules/cloud_service_providers/vmware/tests/src/Traits/VmwareTestFormDataTrait.php...
Checking patch modules/cloud_service_providers/vmware/vmware.install...
Checking patch modules/cloud_service_providers/vmware/vmware.module...
Checking patch modules/tools/k8s_to_s3/k8s_to_s3.module...
Checking patch src/Controller/CloudServerTemplateAccessControlHandler.php...
Checking patch src/Controller/CloudServerTemplateController.php...
Checking patch src/Controller/CloudServerTemplateListBuilder.php...
Checking patch src/Entity/CloudConfig.php...
Checking patch src/Entity/CloudProject.php...
Checking patch src/Entity/CloudServerTemplate.php...
Checking patch src/Entity/CloudServerTemplateInterface.php...
Checking patch src/Entity/CloudServerTemplateStorage.php...
Checking patch src/Entity/CloudServerTemplateStorageInterface.php...
Checking patch src/Entity/CloudServerTemplateType.php...
Checking patch src/Entity/CloudServerTemplateTypeInterface.php...
Checking patch src/Entity/CloudServerTemplateTypeListBuilder.php...
Checking patch src/Entity/CloudServerTemplateViewsData.php...
Checking patch src/Form/CloudServerTemplateApproveConfirm.php...
Checking patch src/Form/CloudServerTemplateCopyConfirm.php...
Checking patch src/Form/CloudServerTemplateDeleteForm.php...
Checking patch src/Form/CloudServerTemplateDeleteMultipleForm.php...
Checking patch src/Form/CloudServerTemplateForm.php...
Checking patch src/Form/CloudServerTemplateLaunchConfirm.php...
Checking patch src/Form/CloudServerTemplateProcessMultipleForm.php...
Checking patch src/Form/CloudServerTemplateReviewConfirm.php...
Checking patch src/Form/CloudServerTemplateRevisionDeleteForm.php...
Checking patch src/Form/CloudServerTemplateRevisionRevertForm.php...
Checking patch src/Form/CloudServerTemplateRevisionRevertTranslationForm.php...
Checking patch src/Form/CloudServerTemplateSettingsForm.php...
Checking patch src/Form/CloudStoreCopyConfirm.php...
Checking patch src/Plugin/Action/Config/DeleteCloudServerTemplate.php...
Checking patch src/Plugin/Derivative/CloudDesignMenuLinks.php...
Checking patch src/Plugin/Derivative/CloudServerTemplateCloudContextBundleDeriver.php...
Checking patch src/Plugin/cloud/config/CloudConfigPluginManagerInterface.php...
Checking patch src/Plugin/cloud/project/CloudProjectPluginManager.php...
Checking patch src/Plugin/cloud/server_template/CloudServerTemplatePluginInterface.php...
Checking patch src/Plugin/cloud/server_template/CloudServerTemplatePluginManager.php...
Checking patch src/Plugin/cloud/server_template/CloudServerTemplatePluginManagerInterface.php...
Checking patch src/Plugin/cloud/store/CloudStorePluginManagerInterface.php...
Checking patch src/Plugin/views/field/CloudServerTemplateListLink.php...
Checking patch src/Routing/CloudServerTemplateHtmlRouteProvider.php...
Checking patch src/Routing/CloudServerTemplateTypeHtmlRouteProvider.php...

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new screenshot 2021-02-09 3.57.20.png1.32 MB

@ilgnerfagundes

Thank you for trying to test the patch. I think I know the reason. I included the fixes for the multi-byte characters in the following comments:

https://git.drupalcode.org/search?utf8=%E2%9C%93&search=%E2%80%A6&group_...

With some reason, you downloaded and saved my patch with some inappropriate character encode. In my testing environment, git apply did work:

$ git apply -v /tmp/3197433-3.patch 
Checking patch cloud.install...
Checking patch cloud.links.menu.yml...
Checking patch cloud.links.task.yml...
Checking patch cloud.permissions.yml...
Checking patch cloud.routing.yml...
Checking patch cloud_server_template.page.inc...
Checking patch config/cloud_server_template.api.php...
Checking patch modules/cloud_service_providers/aws_cloud/aws_cloud.install...
Checking patch modules/cloud_service_providers/aws_cloud/aws_cloud.module...
Checking patch modules/cloud_service_providers/aws_cloud/src/Entity/Ec2/AwsCloudViewBuilder.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Form/Ec2/InstanceLaunchForm.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Plugin/Derivative/AwsCloudMenuLinks.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Plugin/Field/FieldFormatter/InstanceTypeLinkFormatter.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Plugin/Validation/Constraint/AWSConstraintValidator.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Plugin/cloud/server_template/AwsCloudServerTemplatePlugin.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2BatchOperations.php...
Checking patch modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2ServiceInterface.php...
Checking patch modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/InstanceExtraTest.php...
Checking patch modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/InstanceTest.php...
Checking patch modules/cloud_service_providers/aws_cloud/tests/src/Functional/cloud/server_template/CloudServerTemplateTest.php...
Checking patch modules/cloud_service_providers/aws_cloud/tests/src/Traits/AwsCloudTestEntityTrait.php...
Checking patch modules/cloud_service_providers/aws_cloud/tests/src/Traits/AwsCloudTestFormDataTrait.php...
Checking patch modules/cloud_service_providers/k8s/k8s.install...
Checking patch modules/cloud_service_providers/k8s/k8s.module...
Checking patch modules/cloud_service_providers/k8s/src/Plugin/Validation/Constraint/YamlObjectSupportConstraint.php...
Checking patch modules/cloud_service_providers/k8s/src/Plugin/cloud/project/K8sCloudProjectPlugin.php...
Checking patch modules/cloud_service_providers/k8s/src/Plugin/cloud/server_template/K8sCloudServerTemplatePlugin.php...
Checking patch modules/cloud_service_providers/k8s/src/Service/K8sService.php...
Checking patch modules/cloud_service_providers/k8s/src/Service/K8sServiceInterface.php...
Checking patch modules/cloud_service_providers/k8s/tests/src/Functional/cloud/server_template/CloudServerTemplateTest.php...
Checking patch modules/cloud_service_providers/k8s/tests/src/Traits/K8sTestEntityTrait.php...
Checking patch modules/cloud_service_providers/k8s/tests/src/Traits/K8sTestFormDataTrait.php...
Checking patch modules/cloud_service_providers/openstack/openstack.module...
Checking patch modules/cloud_service_providers/openstack/src/Form/OpenStackInstanceLaunchForm.php...
Checking patch modules/cloud_service_providers/openstack/src/Plugin/Derivative/OpenStackMenuLinks.php...
Checking patch modules/cloud_service_providers/openstack/src/Plugin/cloud/server_template/OpenStackServerTemplatePlugin.php...
Checking patch modules/cloud_service_providers/openstack/tests/src/Functional/OpenStack/OpenStackInstanceExtraTest.php...
Checking patch modules/cloud_service_providers/openstack/tests/src/Functional/OpenStack/OpenStackInstanceTest.php...
Checking patch modules/cloud_service_providers/openstack/tests/src/Functional/cloud/server_template/CloudServerTemplateTest.php...
Checking patch modules/cloud_service_providers/openstack/tests/src/Traits/OpenStackTestEntityTrait.php...
Checking patch modules/cloud_service_providers/openstack/tests/src/Traits/OpenStackTestFormDataTrait.php...
Checking patch modules/cloud_service_providers/vmware/src/Plugin/cloud/server_template/VmwareCloudServerTemplatePlugin.php...
Checking patch modules/cloud_service_providers/vmware/tests/src/Functional/cloud/server_template/CloudServerTemplateTest.php...
Checking patch modules/cloud_service_providers/vmware/tests/src/Traits/VmwareTestFormDataTrait.php...
Checking patch modules/cloud_service_providers/vmware/vmware.install...
Checking patch modules/cloud_service_providers/vmware/vmware.module...
Checking patch modules/tools/k8s_to_s3/k8s_to_s3.module...
Checking patch src/Controller/CloudServerTemplateAccessControlHandler.php...
Checking patch src/Controller/CloudServerTemplateController.php...
Checking patch src/Controller/CloudServerTemplateListBuilder.php...
Checking patch src/Entity/CloudConfig.php...
Checking patch src/Entity/CloudProject.php...
Checking patch src/Entity/CloudServerTemplate.php...
Checking patch src/Entity/CloudServerTemplateInterface.php...
Checking patch src/Entity/CloudServerTemplateStorage.php...
Checking patch src/Entity/CloudServerTemplateStorageInterface.php...
Checking patch src/Entity/CloudServerTemplateType.php...
Checking patch src/Entity/CloudServerTemplateTypeInterface.php...
Checking patch src/Entity/CloudServerTemplateTypeListBuilder.php...
Checking patch src/Entity/CloudServerTemplateViewsData.php...
Checking patch src/Form/CloudServerTemplateApproveConfirm.php...
Checking patch src/Form/CloudServerTemplateCopyConfirm.php...
Checking patch src/Form/CloudServerTemplateDeleteForm.php...
Checking patch src/Form/CloudServerTemplateDeleteMultipleForm.php...
Checking patch src/Form/CloudServerTemplateForm.php...
Checking patch src/Form/CloudServerTemplateLaunchConfirm.php...
Checking patch src/Form/CloudServerTemplateProcessMultipleForm.php...
Checking patch src/Form/CloudServerTemplateReviewConfirm.php...
Checking patch src/Form/CloudServerTemplateRevisionDeleteForm.php...
Checking patch src/Form/CloudServerTemplateRevisionRevertForm.php...
Checking patch src/Form/CloudServerTemplateRevisionRevertTranslationForm.php...
Checking patch src/Form/CloudServerTemplateSettingsForm.php...
Checking patch src/Form/CloudStoreCopyConfirm.php...
Checking patch src/Plugin/Action/Config/DeleteCloudServerTemplate.php...
Checking patch src/Plugin/Derivative/CloudDesignMenuLinks.php...
Checking patch src/Plugin/Derivative/CloudServerTemplateCloudContextBundleDeriver.php...
Checking patch src/Plugin/cloud/config/CloudConfigPluginManagerInterface.php...
Checking patch src/Plugin/cloud/project/CloudProjectPluginManager.php...
Checking patch src/Plugin/cloud/server_template/CloudServerTemplatePluginInterface.php...
Checking patch src/Plugin/cloud/server_template/CloudServerTemplatePluginManager.php...
Checking patch src/Plugin/cloud/server_template/CloudServerTemplatePluginManagerInterface.php...
Checking patch src/Plugin/cloud/store/CloudStorePluginManagerInterface.php...
Checking patch src/Plugin/views/field/CloudServerTemplateListLink.php...
Checking patch src/Routing/CloudServerTemplateHtmlRouteProvider.php...
Checking patch src/Routing/CloudServerTemplateTypeHtmlRouteProvider.php...
Applied patch cloud.install cleanly.
Applied patch cloud.links.menu.yml cleanly.
Applied patch cloud.links.task.yml cleanly.
Applied patch cloud.permissions.yml cleanly.
Applied patch cloud.routing.yml cleanly.
Applied patch cloud_server_template.page.inc cleanly.
Applied patch config/cloud_server_template.api.php cleanly.
Applied patch modules/cloud_service_providers/aws_cloud/aws_cloud.install cleanly.
Applied patch modules/cloud_service_providers/aws_cloud/aws_cloud.module cleanly.
Applied patch modules/cloud_service_providers/aws_cloud/src/Entity/Ec2/AwsCloudViewBuilder.php cleanly.
Applied patch modules/cloud_service_providers/aws_cloud/src/Form/Ec2/InstanceLaunchForm.php cleanly.
Applied patch modules/cloud_service_providers/aws_cloud/src/Plugin/Derivative/AwsCloudMenuLinks.php cleanly.
Applied patch modules/cloud_service_providers/aws_cloud/src/Plugin/Field/FieldFormatter/InstanceTypeLinkFormatter.php cleanly.
Applied patch modules/cloud_service_providers/aws_cloud/src/Plugin/Validation/Constraint/AWSConstraintValidator.php cleanly.
Applied patch modules/cloud_service_providers/aws_cloud/src/Plugin/cloud/server_template/AwsCloudServerTemplatePlugin.php cleanly.
Applied patch modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2BatchOperations.php cleanly.
Applied patch modules/cloud_service_providers/aws_cloud/src/Service/Ec2/Ec2ServiceInterface.php cleanly.
Applied patch modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/InstanceExtraTest.php cleanly.
Applied patch modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/InstanceTest.php cleanly.
Applied patch modules/cloud_service_providers/aws_cloud/tests/src/Functional/cloud/server_template/CloudServerTemplateTest.php cleanly.
Applied patch modules/cloud_service_providers/aws_cloud/tests/src/Traits/AwsCloudTestEntityTrait.php cleanly.
Applied patch modules/cloud_service_providers/aws_cloud/tests/src/Traits/AwsCloudTestFormDataTrait.php cleanly.
Applied patch modules/cloud_service_providers/k8s/k8s.install cleanly.
Applied patch modules/cloud_service_providers/k8s/k8s.module cleanly.
Applied patch modules/cloud_service_providers/k8s/src/Plugin/Validation/Constraint/YamlObjectSupportConstraint.php cleanly.
Applied patch modules/cloud_service_providers/k8s/src/Plugin/cloud/project/K8sCloudProjectPlugin.php cleanly.
Applied patch modules/cloud_service_providers/k8s/src/Plugin/cloud/server_template/K8sCloudServerTemplatePlugin.php cleanly.
Applied patch modules/cloud_service_providers/k8s/src/Service/K8sService.php cleanly.
Applied patch modules/cloud_service_providers/k8s/src/Service/K8sServiceInterface.php cleanly.
Applied patch modules/cloud_service_providers/k8s/tests/src/Functional/cloud/server_template/CloudServerTemplateTest.php cleanly.
Applied patch modules/cloud_service_providers/k8s/tests/src/Traits/K8sTestEntityTrait.php cleanly.
Applied patch modules/cloud_service_providers/k8s/tests/src/Traits/K8sTestFormDataTrait.php cleanly.
Applied patch modules/cloud_service_providers/openstack/openstack.module cleanly.
Applied patch modules/cloud_service_providers/openstack/src/Form/OpenStackInstanceLaunchForm.php cleanly.
Applied patch modules/cloud_service_providers/openstack/src/Plugin/Derivative/OpenStackMenuLinks.php cleanly.
Applied patch modules/cloud_service_providers/openstack/src/Plugin/cloud/server_template/OpenStackServerTemplatePlugin.php cleanly.
Applied patch modules/cloud_service_providers/openstack/tests/src/Functional/OpenStack/OpenStackInstanceExtraTest.php cleanly.
Applied patch modules/cloud_service_providers/openstack/tests/src/Functional/OpenStack/OpenStackInstanceTest.php cleanly.
Applied patch modules/cloud_service_providers/openstack/tests/src/Functional/cloud/server_template/CloudServerTemplateTest.php cleanly.
Applied patch modules/cloud_service_providers/openstack/tests/src/Traits/OpenStackTestEntityTrait.php cleanly.
Applied patch modules/cloud_service_providers/openstack/tests/src/Traits/OpenStackTestFormDataTrait.php cleanly.
Applied patch modules/cloud_service_providers/vmware/src/Plugin/cloud/server_template/VmwareCloudServerTemplatePlugin.php cleanly.
Applied patch modules/cloud_service_providers/vmware/tests/src/Functional/cloud/server_template/CloudServerTemplateTest.php cleanly.
Applied patch modules/cloud_service_providers/vmware/tests/src/Traits/VmwareTestFormDataTrait.php cleanly.
Applied patch modules/cloud_service_providers/vmware/vmware.install cleanly.
Applied patch modules/cloud_service_providers/vmware/vmware.module cleanly.
Applied patch modules/tools/k8s_to_s3/k8s_to_s3.module cleanly.
Applied patch src/Controller/CloudServerTemplateAccessControlHandler.php cleanly.
Applied patch src/Controller/CloudServerTemplateController.php cleanly.
Applied patch src/Controller/CloudServerTemplateListBuilder.php cleanly.
Applied patch src/Entity/CloudConfig.php cleanly.
Applied patch src/Entity/CloudProject.php cleanly.
Applied patch src/Entity/CloudServerTemplate.php cleanly.
Applied patch src/Entity/CloudServerTemplateInterface.php cleanly.
Applied patch src/Entity/CloudServerTemplateStorage.php cleanly.
Applied patch src/Entity/CloudServerTemplateStorageInterface.php cleanly.
Applied patch src/Entity/CloudServerTemplateType.php cleanly.
Applied patch src/Entity/CloudServerTemplateTypeInterface.php cleanly.
Applied patch src/Entity/CloudServerTemplateTypeListBuilder.php cleanly.
Applied patch src/Entity/CloudServerTemplateViewsData.php cleanly.
Applied patch src/Form/CloudServerTemplateApproveConfirm.php cleanly.
Applied patch src/Form/CloudServerTemplateCopyConfirm.php cleanly.
Applied patch src/Form/CloudServerTemplateDeleteForm.php cleanly.
Applied patch src/Form/CloudServerTemplateDeleteMultipleForm.php cleanly.
Applied patch src/Form/CloudServerTemplateForm.php cleanly.
Applied patch src/Form/CloudServerTemplateLaunchConfirm.php cleanly.
Applied patch src/Form/CloudServerTemplateProcessMultipleForm.php cleanly.
Applied patch src/Form/CloudServerTemplateReviewConfirm.php cleanly.
Applied patch src/Form/CloudServerTemplateRevisionDeleteForm.php cleanly.
Applied patch src/Form/CloudServerTemplateRevisionRevertForm.php cleanly.
Applied patch src/Form/CloudServerTemplateRevisionRevertTranslationForm.php cleanly.
Applied patch src/Form/CloudServerTemplateSettingsForm.php cleanly.
Applied patch src/Form/CloudStoreCopyConfirm.php cleanly.
Applied patch src/Plugin/Action/Config/DeleteCloudServerTemplate.php cleanly.
Applied patch src/Plugin/Derivative/CloudDesignMenuLinks.php cleanly.
Applied patch src/Plugin/Derivative/CloudServerTemplateCloudContextBundleDeriver.php cleanly.
Applied patch src/Plugin/cloud/config/CloudConfigPluginManagerInterface.php cleanly.
Applied patch src/Plugin/cloud/project/CloudProjectPluginManager.php cleanly.
Applied patch src/Plugin/cloud/server_template/CloudServerTemplatePluginInterface.php cleanly.
Applied patch src/Plugin/cloud/server_template/CloudServerTemplatePluginManager.php cleanly.
Applied patch src/Plugin/cloud/server_template/CloudServerTemplatePluginManagerInterface.php cleanly.
Applied patch src/Plugin/cloud/store/CloudStorePluginManagerInterface.php cleanly.
Applied patch src/Plugin/views/field/CloudServerTemplateListLink.php cleanly.
Applied patch src/Routing/CloudServerTemplateHtmlRouteProvider.php cleanly.
Applied patch src/Routing/CloudServerTemplateTypeHtmlRouteProvider.php cleanly.

Two similar comments * If the same instance name exists, the number suffix (#2, #3…) need to be like my screenshot:

7.20.png

So could you please confirm the patch file's character encoding?

baldwinlouie’s picture

baldwinlouie commented

@yas The patch looks good.

MasatoTakada’s picture

MasatoTakada commented

@yas

It looks good to me.

Masato

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@sekinet @baldwinlouie @masatotakada

Thank you for your review. I'll merge the patch to 3.x and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

  • yas committed 2588837 on 3.x 
    Issue #3197433 by yas, baldwinlouie, sekinet, MasatoTakada: Refactor...

yas closed merge request !137

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.