Problem/Motivation

Fix an issue while deleting a K8s scheduler

CommentFileSizeAuthor
#6 3197432-6.patch10.24 KBxiaohua guan
#3 3197432.diff5.35 KBxiaohua guan

Issue fork cloud-3197432

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan opened merge request !138

xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review
StatusFileSize
new 3197432.diff5.35 KB
xiaohua guan’s picture

xiaohua guan commented

@yas

Method getCloudContext(), created(), changed() are used in the parent class CloudContentEntityBase, I can't add return types without modifying the class CloudContentEntityBase.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@xiaohua-guan

Thank you for the update. I just posted my above comments; can we add the return type hint for the rest of the functions?

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review
StatusFileSize
new 3197432-6.patch10.24 KB
xiaohua guan’s picture

xiaohua guan commented

@yas

Thanks for your review. I've added return type for setXXX functions. Please take a look. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@xiaohua-guan

Thank you for the update. Could you please add the return type hint to baseFieldDefinitions(EntityTypeInterface $entity_type): array?

Thanks

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

I added the return type. Please take a look again. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the update. I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed c77d6d3 on 3.x authored by Xiaohua Guan 
    Issue #3197432 by Xiaohua Guan, yas: Fix an issue while deleting a K8s...

yas closed merge request !138

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.