CommentFileSizeAuthor
#17 3117066-17.patch631 bytesishani.addweb
#11 3117066-11.patch500 bytesyas
#5 3117066-5.patch22.22 KBishani.addweb
#5 3117066-5-interdiff.txt5.14 KBishani.addweb
#4 screenshot 2020-03-03 13.46.17.png1.58 MByas
#3 3117066-3.patch21.55 KBishani.addweb
#2 3117066-2.patch21.53 KBishani.addweb

Comments

Ishani.addweb created an issue. See original summary.

ishani.addweb’s picture

ishani.addweb commented
Status: Active » Needs review
StatusFileSize
new 3117066-2.patch21.53 KB
ishani.addweb’s picture

ishani.addweb commented
StatusFileSize
new 3117066-3.patch21.55 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
StatusFileSize
new screenshot 2020-03-03 13.46.17.png1.58 MB

@ishaniaddweb

Thank you for adding the feature. Looks good; could you please modify as follows?

17.png

ishani.addweb’s picture

ishani.addweb commented
Status: Needs work » Needs review
StatusFileSize
new 3117066-5-interdiff.txt5.14 KB
new 3117066-5.patch22.22 KB

@yas Done all above changes as you suggested.
Please review and let me know if needs any changes.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#3095569: Composer could not parse version constraint / could not load package (2)

@ishaniaddweb

Thank you for the update. It looks good to me now. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

  • yas committed ae4207e on 8.x-1.x authored by Ishani.addweb 
    Issue #3117066 by Ishani.addweb, yas: Manage private AMI images

  • yas committed 0017c61 on 8.x-2.x authored by Ishani.addweb 
    Issue #3117066 by Ishani.addweb, yas: Manage private AMI images
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs work

@all

We need to fix the coding standard violation.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 3117066-11.patch500 bytes
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@all

I'll merge this hotfix patch.

  • yas committed 73497de on 8.x-1.x 
    Issue #3117066 by Ishani.addweb, yas: Hotfix - Manage private AMI images

  • yas committed 3c9ac50 on 8.x-2.x 
    Issue #3117066 by Ishani.addweb, yas: Hotfix - Manage private AMI images
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs work

@ishaniaddweb

Please let us re-open this issue since this patch might have caused some test case errors.

ishani.addweb’s picture

ishani.addweb commented
Status: Needs work » Needs review
StatusFileSize
new 3117066-17.patch631 bytes

@yas

Fixed all testcases error.

Please test updated patch.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ishaniaddweb

Thank you for fixing it. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

  • yas committed 210f992 on 8.x-1.x authored by Ishani.addweb 
    Issue #3117066 by Ishani.addweb, yas: Hotfix - Manage private AMI images

  • yas committed 1303d13 on 8.x-2.x authored by Ishani.addweb 
    Issue #3117066 by Ishani.addweb, yas: Hotfix - Manage private AMI images
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Manage private AMI images » Manage private AMI images (1)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.