CommentFileSizeAuthor
#6 screenshot-tests-2019-11-24b.png796.96 KByas
#6 screenshot-tests-2019-11-24a.png819.47 KByas
#6 screenshot-2019-11-24f.png885.8 KByas
#6 screenshot-2019-11-24e.png891.92 KByas
#6 screenshot-2019-11-24d.png876.7 KByas
#6 screenshot-2019-11-24c.png886.28 KByas
#6 screenshot-2019-11-24b.png877.8 KByas
#6 screenshot-2019-11-24a.png882.16 KByas
#2 3096407-2.patch7.46 KBxiaohua guan

Comments

Xiaohua Guan created an issue. See original summary.

xiaohua guan’s picture

xiaohua guan commented
StatusFileSize
new 3096407-2.patch7.46 KB
xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review
xiaohua guan’s picture

xiaohua guan commented
Status: Needs review » Active
xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review

@yas

Please review the patch file. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new screenshot-2019-11-24a.png882.16 KB
new screenshot-2019-11-24b.png877.8 KB
new screenshot-2019-11-24c.png886.28 KB
new screenshot-2019-11-24d.png876.7 KB
new screenshot-2019-11-24e.png891.92 KB
new screenshot-2019-11-24f.png885.8 KB
new screenshot-tests-2019-11-24a.png819.47 KB
new screenshot-tests-2019-11-24b.png796.96 KB

@xiaohua-guan

Thank you for adding the feature. I tested it and looks good to me. I'll merge the patch to 8.x-2.x and close this issue as Fixed.

screenshot-2019-11-24a.png
screenshot-2019-11-24b.png
screenshot-2019-11-24c.png
screenshot-2019-11-24d.png
screenshot-2019-11-24e.png
screenshot-2019-11-24f.png

screenshot-tests-2019-11-24a.png
screenshot-tests-2019-11-24b.png

  • yas committed 95efd86 on 8.x-2.x authored by Xiaohua Guan 
    Issue #3096407 by Xiaohua Guan, yas: Add any / own permissions to...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3095569: Composer could not parse version constraint / could not load package (2)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.