• In ServerTemplate Edit / Detailed view, add AMI ID besides Image Name
CommentFileSizeAuthor
#25 3080784-25-8.x-2.x-interdiff.txt23.41 KByas
#25 3080784-25-8.x-1.x-interdiff.txt22.81 KByas
#25 3080784-25-8.x-2.x.patch124.06 KByas
#25 3080784-25-8.x-1.x.patch124.12 KByas
3080784-22-8.x-2.x-interdiff.txt22.92 KByas
3080784-22-8.x-1.x-interdiff.txt22.33 KByas
3080784-22-8.x-2.x.patch123.92 KByas
3080784-22-8.x-1.x.patch123.98 KByas
#20 3080784-20-8.x-2.x-interdiff.txt1.82 KByas
#20 3080784-20-8.x-1.x-interdiff.txt1.82 KByas
#20 3080784-20-8.x-2.x.patch127.36 KByas
#20 3080784-20-8.x-1.x.patch127.36 KByas
#13 3080784-13-8.x-1.x.patch127.35 KByas
#13 3080784-13-8.x-2.x.patch0 bytesyas
#12 3080784-12.patch127.35 KByas
#10 3080784-10.patch126.76 KByas
#6 3080784-6.patch35.65 KByas
#4 3080784-4.patch21.88 KByas
#2 3080784-2.patch18.22 KByas
#14 3080784-14-8.x-2.x.patch122.43 KByas
#16 3080784-16.patch126.69 KByas
#18 3080784-17-8.x-2.x.patch127.36 KByas

Comments

yas created an issue. See original summary.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 3080784-2.patch18.22 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3080784-2.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 3080784-4.patch21.88 KB

Fixing it.

Status: Needs review » Needs work

The last submitted patch, 4: 3080784-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3080784-6.patch35.65 KB

Updated the patch.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: 3080784-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 3080784-10.patch126.76 KB

Fixing the issue and making it more robust code.

For example, since we use a mock data (YAML) file as a return value of AWS PHP SDK library instead of making an actual API call and foreach statement doesn't accept a NULL value.

FROM:

  foreach ($result['Instances'] as $instance) {
    ...
  }

TO:

  foreach ($result['Instances'] ?: [] as $instance) {
    ...
  }

FROM:

if ($result != NULL) {
...
}

TO:

if (isset($result)) {
...
}

Status: Needs review » Needs work

The last submitted patch, 10: 3080784-10.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 3080784-12.patch127.35 KB

Fixing the issue.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3080784-13-8.x-1.x.patch127.35 KB
new 3080784-13-8.x-2.x.patch0 bytes

Re-rolling the patch for 8.x-2.x

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3080784-14-8.x-2.x.patch122.43 KB

Fixing the patch for 8.x-2.x.

Status: Needs review » Needs work

The last submitted patch, 14: 3080784-14-8.x-2.x.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 3080784-16.patch126.69 KB

Fixing the patch for 8.x-2.x.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinloue
@xiaohua-guan
@masami

Could you please review the patch? Note that I separated the InstanceTest as three tests by keeping the same tests.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3080784-17-8.x-2.x.patch127.36 KB

Updated to align in between 8.x-1.x and 8.x-2.x.

baldwinlouie’s picture

baldwinlouie commented

@yas, this is a great patch. I only have one comment below.

+++ b/modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/InstanceBulkTest.php
@@ -0,0 +1,146 @@
+  const AWS_CLOUD_INSTANCE_REPEAT_COUNT = 1;

Should this count be three?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3080784-20-8.x-1.x.patch127.36 KB
new 3080784-20-8.x-2.x.patch127.36 KB
new 3080784-20-8.x-1.x-interdiff.txt1.82 KB
new 3080784-20-8.x-2.x-interdiff.txt1.82 KB

@baldwinlouie

Thank you for your review. I forgot to revert the repeat count (-_-; I updated the patches. Could you please review those again?

The last submitted patch, 20: 3080784-20-8.x-1.x.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

Thanks to @baldwinlouie, after changing the number of repeat count, I found the bug. So I re-created the patches.

The last submitted patch, 3080784-22-8.x-1.x.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 3080784-22-8.x-2.x.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 3080784-25-8.x-1.x.patch124.12 KB
new 3080784-25-8.x-2.x.patch124.06 KB
new 3080784-25-8.x-1.x-interdiff.txt22.81 KB
new 3080784-25-8.x-2.x-interdiff.txt23.41 KB

Re-rolling the patches.

baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Reviewed & tested by the community

@yas, this looks good to me!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinlouie

Thank you for your review！ I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

  • yas committed e129a2f on 8.x-1.x 
    Issue #3080784 by yas, baldwinlouie: Add AMI ID on ServerTemplate Edit...

  • yas committed f3e0771 on 8.x-2.x 
    Issue #3080784 by yas, baldwinlouie: Add AMI ID on ServerTemplate Edit...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.