@yas

I reordered the items. And I've already remove Eucalyptus.

CommentFileSizeAuthor
#5 3025937-5.patch9.52 KBxiaohua guan
#2 3025937-2.patch9.08 KBxiaohua guan

Comments

Xiaohua Guan created an issue. See original summary.

xiaohua guan’s picture

StatusFileSize
new9.08 KB
xiaohua guan’s picture

Status: Active » Needs review

@yas

Please review the patch. Thanks.

yas’s picture

Status: Needs review » Needs work

@xiaohua-guan,

Thank you for the patch! Could I ask you to re-order the items as follows? And also, please remove Eucalyptus from Cloud Type options.

    [
      'name' => 'cloud_provider',
      'title' => t('Cloud Provider'),
      'open' => TRUE,
      'fields' => [
        'cloud_context',
        'name',
        'field_description',
      ],
    ],
    [
      'name' => 'credentials',
      'title' => t('Credentials'),
      'open' => TRUE,
      'fields' => [
        'field_cloud_type',
        'field_region',
        'field_access_key',
        'field_secret_key',
        'field_user_id',
      ],
    ],
    [
      'name' => 'api',
      'title' => t('API'),
      'open' => TRUE,
      'fields' => [
        'field_api_version',
        'field_api_endpoint_uri',
      ],
    ],
    [
      'name' => 'image_upload',
      'title' => t('Image Upload'),
      'open' => TRUE,
      'fields' => [
        'field_image_upload_url',
        'field_x_509_certificate',
      ],
    ],
  ];
  $others = [
    'name' => 'others',
    'title' => t('Others'),
    'open' => FALSE,
    'fields' => [
      'revision_log_message',
      'user_id',
    ],
  ];
xiaohua guan’s picture

StatusFileSize
new9.52 KB
xiaohua guan’s picture

Issue summary: View changes
xiaohua guan’s picture

Status: Needs work » Needs review
yas’s picture

Issue summary: View changes

@xiaohua-guan

Thank you for the update. It looks good to me.

@baldwinlouie

What do you think?

baldwinlouie’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

@yas, @xiaohua-guan, This patch looks good!

yas’s picture

@baldwinlouie

Thank you for your review. Then I'll merge the patch and mark this issue as Fixed.

  • yas committed 50af202 on 8.x-1.x authored by Xiaohua Guan
    Issue #3025937 by Xiaohua Guan, yas, baldwinlouie: Categorize (add...
yas’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.