Provide the list of Security Groups depending on a selected VPC in ServerTemplate editing page

@xiaohua-guan

Thank you for providing the great patch! I think this patch will be able to make the usability even better.

1. I would like to ask you is in the VPC dropdown list:

   BEFORE:

   vpc_name (vpc-abcd1111)
   vpc-abcd2222

   TO:

   vpc_name (vpc-abcd1111)
   vpc-abcd2222 (vpc-abcd2222)

2. Also, could you please re-order the fields (w/ mandatory or optional)?
   Please make the fieldset for AMI, Instance Type, Network, Instance Count, Options and Others.
   • AMI
   • Image Id *
   • Kernel Id
   • Ramdisk Id
   • Network Interface
   • Instance
   • Instance Type *
   • Min Count *
   • Max Count
   • Network
   • Availability Zone *
   • VPC *
   • Subnet *
   • Security Groups *
   • SSH Key *
   • Options
   • Monitoring
   • Instance Shutdown Behavior
   • Schedule
   • User Data
   • Others
   • Authored by
   • Revision log message

Thanks,
Yas

@xiaohua-guan

Thank you for the updated patch！ I tested it, and I found it would be better to apply fieldset to Name and description fields. So I would like to suggest the following again. How do you think? (Note that Network field should be Network Interface)

// To make the fieldsets collapsible.

    $form[$fieldset_name] = [
      '#type' => 'details',
      '#title' => $fieldset_def['title'],
      '#weight' => $weight++,
      '#open' => TRUE,
      '#tree' => TRUE,
    ];

*...Mandatory field below (Show asterisk (*) explicitly)

• Instance
• Name *
• Description
• Instance Type *
• Min Count *
• Max Count
• Test Only
• AMI
• Image Id *
• Kernel Id
• Ramdisk Id
• Network
• Availability Zone *
• VPC *
• Subnet *
• Security Groups *
• SSH Key *
• Network Interface
• Options
• Instance Shutdown Behavior
• Monitoring
• Schedule
• User Data
• Others => This fieldsets should be '#open' => FALSE,
• Cloud Provider Machine Name
• Authored by
• Revision log message

@xiaohua-guan

Thank you for the updated patch that I requested. I tested it; and it looks so nice to me as expected, therefore I'll merge it.

I merged the patch. Let us mark this issue as Fixed.