In baseFieldDefinitions() of Image.php, there is a duplicate definition of root_device_type. This should be removed.

CommentFileSizeAuthor
#2 3012455.patch1.71 KBbaldwinlouie

Comments

baldwinlouie created an issue. See original summary.

baldwinlouie’s picture

baldwinlouie commented
Status: Active » Needs review
StatusFileSize
new 3012455.patch1.71 KB

Attaching patch that removes this.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@baldwinlouie Thank you for your patch. It looks good to me.

  • yas committed cbedf31 on 8.x-1.x authored by baldwinlouie 
    Issue #3012455 by baldwinlouie, yas: Remove duplicate root_device_type...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinlouie Thank you for your contribution. Just my two cents, could I ask you to create a patch by removing the part of path modules/contrib/ from next time?

$ git apply -v 3012455.patch
Checking patch contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Entity/Ec2/Image.php...
error: contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Entity/Ec2/Image.php: No such file or directory
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.