There some hard coding property values in the files mock_data/**/*.yml. It should be replaced with random data.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 3010193_20181031.patch | 74.03 KB | xiaohua guan |
There some hard coding property values in the files mock_data/**/*.yml. It should be replaced with random data.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 3010193_20181031.patch | 74.03 KB | xiaohua guan |
Comments
Comment #2
xiaohua guan commentedComment #3
xiaohua guan commentedI've randomized the data in yml files, and removed useless files, uncommented test cases of deleting.
Comment #4
xiaohua guan commentedComment #6
yas@xiaohua-guan Thank you for your patch.
Just my two cents, how about this one to create the random IP addresses as follows?
For the following YAML properties,
You can create the random IP addresses as follows (I haven't tested, so please make sure if it works or not)
Comment #7
xiaohua guan commentedComment #8
xiaohua guan commentedComment #9
xiaohua guan commented@yas
Thanks for your comment.
I modified the code related to private ip, public ip and cidr as the way you showed. And I also move such code to a new class Utils.
Please confirm the patch file 3010193_20181031.patch.
Comment #10
yas@xiaohua-guan Thank you for the modification. It looks good to me.
Comment #11
baldwinlouie commented@xiaohua-guan and @yas, This patch looks good! Moving to RTBC
Comment #14
yas@xiaohua-guan and @baldwinlouie Thank you for your contributions. We mark this issue as 'Fixed'.