Problem

Closure Compiler can optionally use a local Java instance and the Google Closure Compiler jar rather than relying on the Google compilation service.

The administration page tests for the presence of Java by running shell_exec('java') and checking for a usage string, however some Java implementations return this as an error response (stderr) instead and so this check fails.

Proposed resolution

Adjust the check so that it includes Java implementations which return an stderr response.

Comments

markpavlitski’s picture

Assigned: markpavlitski » Unassigned
Status: Active » Needs review
StatusFileSize
new426 bytes

This patch includes stderr output in the response, and so allows the check to pass.

  • Commit 700c330 on 7.x-2.x by nburles:
    Issues #2271803 and #2271895 by markpavlitski: Fix bugs detecting java...
nburles’s picture

Status: Needs review » Closed (fixed)

Many thanks for the bug reports... and infinitely more for submitting working patches along with them!

I've tested and committed the fixes, and version 2.3 should become available shortly.