Closed (fixed)
Project:
Clientside Validation
Version:
3.0.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
11 Aug 2022 at 12:38 UTC
Updated:
2 Sep 2022 at 13:09 UTC
Jump to comment: Most recent
Comments
Comment #2
johnpitcairn commentedRats. I'd call that major.
Comment #3
johnpitcairn commentedLooks like
ModuleHandler::invokeAllWith()was added in Drupal 9.4. We should not be using it and still claiming compatibility as core ^9 || ^10.Either increase the minimum requirement to 9.4, or revert to the previous implementation in
clientside_validation_should_validate()until 9.3.x is unsupported.Given we are at release candidate status, we should not be introducing compatibility breaks. We should revert. Opinions?
Comment #4
johnpitcairn commentedDiscussion is happening in #3286539: Automated Drupal 10 compatibility fixes
For now, revert to commit #77ff5d137 which is the last dev release before 3.0.0-rc6 introduced this.
Comment #5
joseph.olstad@John Pitcairn,
yes it's due to #3286539: Automated Drupal 10 compatibility fixes
Comment #7
nikunjkotechahttps://www.drupal.org/project/clientside_validation/releases/3.0.1 added with the code reverted
https://www.drupal.org/project/clientside_validation/releases/4.0.0 added with the code and also added minimum required version as 9.4