Defined Installation path for the plugin /libraries/ckeditor/plugins/lineheight, but if you download libraries via composer it is /libraries/lineheight.
Patch in attachment.
Also added composer.json with plugin repository.

CommentFileSizeAuthor
#6 ckeditor_lineheight-2956943-6.patch7.02 KBanish.a
#5 ckeditor_lineheight-2956943-5.patch0 bytesanish.a
#4 2956943-4.patch6.78 KBnwom
#2 2956943_ckeditor_lineheight_library_path.patch468 bytesastonvictor
ckeditor_lineheight-1.patch1.94 KBblackiceua

Comments

BlacKICEUA created an issue. See original summary.

astonvictor’s picture

astonvictor commented
StatusFileSize
new 2956943_ckeditor_lineheight_library_path.patch468 bytes

Added a patch that updates the library path.

abh.ai’s picture

abh.ai commented

You don't need this patch. You can specify where you want to install in your composer.json file.
Under repositories, add this:

{
        "type": "package",
        "package": {
          "name": "ckeditor-plugin/lineheight",
          "version": "1.0.4",
          "type": "drupal-library",
          "extra": {
            "installer-name": "ckeditor/plugins/lineheight"
          },
          "dist": {
            "url": "https://download.ckeditor.com/lineheight/releases/lineheight_1.0.4.zip",
            "type": "zip"
          }
        }
      },
nwom’s picture

nwom commented
Title: Installation path for the plugin » Add Composer automatic library downloading via Composer Merge Plugin
StatusFileSize
new 2956943-4.patch6.78 KB

Webform and a few other modules use the Composer Merge Plugin to automatically download the library and keep the library up-to-date using a composer.libraries.json instead of adding it to the composer.json of the module itself

I felt it would be beneficial for this module as well, so I copied an implementation done by the patch here: #3024597: Using composer to install library as done in Webform module and added the change in the above patch. Please review!

anish.a’s picture

anish.a commented
Assigned: Unassigned » anish.a
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new ckeditor_lineheight-2956943-5.patch0 bytes

Tested the changes. Added backward compatibility with previous path.

anish.a’s picture

anish.a commented
StatusFileSize
new ckeditor_lineheight-2956943-6.patch7.02 KB

Adding correct patch.

  • anish.a committed 6c9130a on 8.x-1.x authored by NWOM 
    Issue #2956943 by BlacKICEUA, anish.a, Aston Victor, NWOM: Add Composer...
anish.a’s picture

anish.a commented
anish.a’s picture

anish.a commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.