There are some CS issues.

CommentFileSizeAuthor
#5 2996498-coding-standard-5.patch2.47 KBdeepanker_bhalla
#3 coding standard_CKEditor frame(2).png59.9 KBzalak.addweb
#3 coding standard_CKEditor frame.png25.55 KBzalak.addweb
#2 2996498_ckeditor_frame_cs_fix.patch1.46 KBastonvictor

Comments

Aston Victor created an issue. See original summary.

astonvictor’s picture

astonvictor commented
Status: Active » Needs review
StatusFileSize
new 2996498_ckeditor_frame_cs_fix.patch1.46 KB
zalak.addweb’s picture

zalak.addweb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new coding standard_CKEditor frame.png25.55 KB
new coding standard_CKEditor frame(2).png59.9 KB

@Aston Victor, As per your changes, your patch is working fine. I review it with the help of pareview & attached the S.S for the same.

deepanker_bhalla’s picture

deepanker_bhalla commented
Status: Reviewed & tested by the community » Needs work

@Aston Victor: Good work. I can confirm the patch #2 is applying cleanly. Here is the output:

❯ ckeditor_frame 8.x-1.x* git apply -v 2996498_ckeditor_frame_cs_fix.patch
Checking patch ckeditor_frame.module...
Checking patch src/Plugin/CKEditorPlugin/CKEditorFrame.php...
Applied patch ckeditor_frame.module cleanly.
Applied patch src/Plugin/CKEditorPlugin/CKEditorFrame.php cleanly.
_________________________________________________________________________________________________________

But after checking with phpcs --standard=Drupal ckeditor_frame/....... I am getting some more issues i.e.

FILE: /var/www/html/tolearn/modules/git/ckeditor_frame/README.txt
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
 22 | WARNING | Line exceeds 80 characters; contains 84 characters
 27 | WARNING | Line exceeds 80 characters; contains 88 characters
 28 | WARNING | Line exceeds 80 characters; contains 94 characters
----------------------------------------------------------------------
deepanker_bhalla’s picture

deepanker_bhalla commented
Status: Needs work » Needs review
StatusFileSize
new 2996498-coding-standard-5.patch2.47 KB

Thus updating the patch with the consolidated fixes of the old and new ones.

Anonymous’s picture

Anonymous (not verified) commented

Hello,

Thanks you for you exchanges, I will commit this changes soon.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.