The ckeditor5_premium_features_fullscreen module doesn't have a direct dependency on the ckeditor5_premium_features module and can be installed separately. However, during the uninstall process, it tries to call a ckeditor5_premium_features_remove_ckeditor_plugins function which doesn't exist if the ckeditor5_premium_features module is not installed. This leads to an inability to remove the module.

function ckeditor5_premium_features_fullscreen_uninstall($is_syncing) {
  ckeditor5_premium_features_remove_ckeditor_plugins(['fullScreen']);
}

The workaround is to install ckeditor5_premium_features and remove the deprecated module.

This issue can be fixed by copying the ckeditor5_premium_features_remove_ckeditor_plugins function code into the ckeditor5_premium_features_fullscreen_uninstall hook, or by adding a direct dependency on the ckeditor5_premium_features module and providing an update hook to install the main module.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

seonic created an issue. See original summary.

seonic’s picture

Issue summary: View changes
salmonek’s picture

Hi seonic

Thank you for bringing this issue to our attention. I totally forgot that main module is not a dependency here.
I went for updating ckeditor5_premium_features_fullscreen_uninstall with the adaptation of the function from main module. I'll publish a MR with patch in a few minutes.

salmonek’s picture

Status: Active » Needs review

Patch is ready.

salmonek’s picture

Status: Needs review » Reviewed & tested by the community

Tested and approved by our QA team.

salmonek’s picture

Released in 1.7.0

salmonek’s picture

Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.