The ckeditor5_premium_features_fullscreen module doesn't have a direct dependency on the ckeditor5_premium_features module and can be installed separately. However, during the uninstall process, it tries to call a ckeditor5_premium_features_remove_ckeditor_plugins function which doesn't exist if the ckeditor5_premium_features module is not installed. This leads to an inability to remove the module.
function ckeditor5_premium_features_fullscreen_uninstall($is_syncing) {
ckeditor5_premium_features_remove_ckeditor_plugins(['fullScreen']);
}
The workaround is to install ckeditor5_premium_features and remove the deprecated module.
This issue can be fixed by copying the ckeditor5_premium_features_remove_ckeditor_plugins function code into the ckeditor5_premium_features_fullscreen_uninstall hook, or by adding a direct dependency on the ckeditor5_premium_features module and providing an update hook to install the main module.
Issue fork ckeditor5_premium_features-3564856
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
seonic commentedComment #3
salmonek commentedHi seonic
Thank you for bringing this issue to our attention. I totally forgot that main module is not a dependency here.
I went for updating
ckeditor5_premium_features_fullscreen_uninstallwith the adaptation of the function from main module. I'll publish a MR with patch in a few minutes.Comment #5
salmonek commentedPatch is ready.
Comment #6
salmonek commentedTested and approved by our QA team.
Comment #7
salmonek commentedReleased in 1.7.0
Comment #8
salmonek commented